Add tokens table #313
Open
Add tokens table #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
reviewed
Dec 17, 2024
DOBEN
force-pushed
the
token_table
branch
2 times, most recently
from
cb68a9c to
b6f8950
Compare
limemloh
requested changes
Dec 20, 2024
backend-rust/src/graphql_api.rs
Outdated
| @@ -2715,19 +2774,24 @@ impl From<String> for AccountAddress { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(SimpleObject)] | |||
| #[graphql(complex)] | |||
There was a problem hiding this comment.
I would prefer if we did not use ComplexObject as much, since it is merging the struct for parsing database rows with the exposed API, which to me seems like a source of subtle breaking changes in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #255
This PR adds tracking of
cis-2tokens.cis-1tokens have not been considered yet.