fixed review comment

Consensys · Nov 15, 2024 · b497da5 · b497da5
1 parent c16d93d
commit b497da5
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 62 deletions.
diff --git a/sdk/doc/cli-examples.md b/sdk/doc/cli-examples.md
@@ -43,7 +43,7 @@
 
     pnpm portal isPortalRegistered '{\"portalAddress\":\"0x8b833796869b5debb9b06370d6d47016f0d7973b\"}'
 
-    pnpm portal getPortalsCount
+    pnpm portal getPortalsNumber
     ```
 
 </details>

diff --git a/sdk/examples/portal/portalExamples.ts b/sdk/examples/portal/portalExamples.ts
@@ -399,6 +399,10 @@ export default class PortalExamples {
       console.log(await this.veraxSdk.portal.getPortalByAddress(portalAddress));
     }
 
+    if (methodName.toLowerCase() == "getPortalsNumber".toLowerCase() || methodName == "") {
+      console.log(await this.veraxSdk.portal.getPortalsNumber());
+    }
+
     if (methodName.toLowerCase() == "isPortalRegistered".toLowerCase() || methodName == "") {
       let params;
       if (argv !== "") params = JSON.parse(argv);

diff --git a/sdk/examples/utils/countUniqueSubjects.ts b/sdk/examples/utils/countUniqueSubjects.ts
@@ -11,7 +11,7 @@ const fetchSubjectsFromFile = async (fileSuffix: number): Promise<string[]> => {
 
 async function main() {
   const veraxSdk = new VeraxSdk(VeraxSdk.DEFAULT_LINEA_MAINNET);
-  const attestationNumber = await veraxSdk.utils.getAttestationIdCounter();
+  const attestationNumber = await veraxSdk.attestation.getAttestationIdCounter();
   const filesNumber = Math.ceil(Number(attestationNumber) / BATCH_SIZE);
 
   const allSubjects: string[][] = [];

diff --git a/sdk/examples/utils/getAllAttestations.ts b/sdk/examples/utils/getAllAttestations.ts
@@ -29,7 +29,7 @@ const fetchAllAttestations = async (batchNumber: number, veraxSdk: VeraxSdk) =>
 
 async function main() {
   const veraxSdk = new VeraxSdk(VeraxSdk.DEFAULT_LINEA_MAINNET);
-  const attestationNumber = await veraxSdk.utils.getAttestationIdCounter();
+  const attestationNumber = await veraxSdk.attestation.getAttestationIdCounter();
   const batchesNumber = Math.ceil(Number(attestationNumber) / BATCH_SIZE);
 
   console.log(`Creating ${batchesNumber} batches of ${BATCH_SIZE} items to get all ${attestationNumber} attestations.`);

diff --git a/sdk/examples/utils/getAttestationIdCounter.ts b/sdk/examples/utils/getAttestationIdCounter.ts
diff --git a/sdk/examples/utils/getModulesNumber.ts b/sdk/examples/utils/getModulesNumber.ts
diff --git a/sdk/examples/utils/getPortalsCount.ts b/sdk/examples/utils/getPortalsCount.ts
diff --git a/sdk/examples/utils/getSchemasNumber.ts b/sdk/examples/utils/getSchemasNumber.ts
diff --git a/subgraph/abis/ModuleRegistry.json b/subgraph/abis/ModuleRegistry.json
@@ -151,19 +151,6 @@
     "stateMutability": "nonpayable",
     "type": "function"
   },
-  {
-    "inputs": [],
-    "name": "getModulesNumber",
-    "outputs": [
-      {
-        "internalType": "uint256",
-        "name": "",
-        "type": "uint256"
-      }
-    ],
-    "stateMutability": "view",
-    "type": "function"
-  },
   {
     "inputs": [],
     "name": "initialize",

diff --git a/subgraph/abis/PortalRegistry.json b/subgraph/abis/PortalRegistry.json
@@ -234,19 +234,6 @@
     "stateMutability": "view",
     "type": "function"
   },
-  {
-    "inputs": [],
-    "name": "getPortalsCount",
-    "outputs": [
-      {
-        "internalType": "uint256",
-        "name": "",
-        "type": "uint256"
-      }
-    ],
-    "stateMutability": "view",
-    "type": "function"
-  },
   {
     "inputs": [],
     "name": "initialize",

diff --git a/subgraph/abis/SchemaRegistry.json b/subgraph/abis/SchemaRegistry.json
@@ -219,19 +219,6 @@
     "stateMutability": "view",
     "type": "function"
   },
-  {
-    "inputs": [],
-    "name": "getSchemasNumber",
-    "outputs": [
-      {
-        "internalType": "uint256",
-        "name": "",
-        "type": "uint256"
-      }
-    ],
-    "stateMutability": "view",
-    "type": "function"
-  },
   {
     "inputs": [],
     "name": "initialize",