Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): Implement a default withdraw function #801

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 13, 2024

What does this PR do?

This PR implements default behaviour of withdraw function at Abstract Portal level
Default portal will also use the same behaviour for withdrawal function

Related ticket

Fixes #790

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.11%. Comparing base (e56a25f) to head (3321d59).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #801       +/-   ##
===========================================
+ Coverage   46.80%   74.11%   +27.31%     
===========================================
  Files          18       49       +31     
  Lines         391      908      +517     
  Branches       59      182      +123     
===========================================
+ Hits          183      673      +490     
- Misses        205      232       +27     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls merged commit 2aca9eb into dev Nov 14, 2024
9 checks passed
@alainncls alainncls deleted the feat/implement-a-default-withdraw-function branch November 14, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Implement a default withdraw function
3 participants