Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds creation of dlq from resources #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds creation of dlq from resources #183

wants to merge 2 commits into from
+57 −2

Conversation

JeisonJHA
Copy link

It adds support for creation of dlq from resources, but only with one format :(

      RedrivePolicy:
        deadLetterTargetArn: # Support only this format for autoCreate
          Fn::GetAtt:
          - MyFourthQueueDlq
          - Arn
        maxReceiveCount: 6

I think it solves #65 partially

@katesclau
Copy link

This CI is failing for

serverless-offline-plugins-integration: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Code looks good though 👍

@luisdemarchi
Copy link

wowww @katesclau @katesclau this feature is valuable, what needs to be approved and merged?

@CodySearsOS
Copy link

Running into this issue with version 7.3.2 when I have a DLQ specified. Figured I'd add a comment to bump in case others are seeing it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katesclau katesclau katesclau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeisonJHA @katesclau @luisdemarchi @CodySearsOS