Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds interpolation gradient testing #43

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Adds interpolation gradient testing #43

merged 3 commits into from
Mar 29, 2022

Conversation

andrevitorelli
Copy link
Contributor

Passing this test is what we need to solve issue #26

@andrevitorelli
Copy link
Contributor Author

This test now fails successfully. :-) (ie. it's failing due to the bug we're trying to solve at #26, as it should, not due to it's own problems)
task_failed_successfully

@EiffL
Copy link
Member

EiffL commented Jan 7, 2022

I found this cool little thing the other day:

import pytest

xfail = pytest.mark.xfail

@xfail(reason="fails because we have a bug not fixed yet")
def test_that_fails():
   ....

which can be used to mark tests that are expected to fail for some reason

EiffL
EiffL approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffL EiffL merged commit 42a1610 into main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EiffL EiffL EiffL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrevitorelli @EiffL