Bug plotting missing Shape Metrics e2 and R2 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeipollack
changed the title
|
@sfarrens I am ready for you to review this PR:
|
sfarrens
approved these changes
Mar 5, 2024
|
Looks OK to me @jeipollack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110 and #94
Refactored the
ShapeMetricsPlotHandlerto reduce duplicated lines, and altered the sequence of commands to produce plots for e1, e2, and R2 shape metrics (see plots below).This PR also applies a fix raised in #92 regarding skipped validation tests.
We want the validation tests to be skipped during CI, but to be ran manually with pytest by the developer. We applied the conditional pytest.mark.skipif decorator and will check if the CI environment variable was defined. If yes, the test is skipped, else the test is run.
Note, 28 files were changed due to rebase with the
developbranch with updated package dependencies.Below I show examples of the Shape metric plots for e1, e2 and R2/MeanR2.