Pre-release v2.0.0 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into refactor_plotting
… into refactor_plotting
sfarrens
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Hi @jeipollack, just a few minor threads to resolve. I don't anticipate any further issues after you merge #85, so once that is done and you have resolve these threads, I believe we can merge this PR too.
Feature unit tests run configs - MetricsConfigHandler Class
sfarrens
reviewed
Nov 16, 2023
sfarrens
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored wf-psf code including:
New changes to config parameter handling to allow for a bit more flexibility for running WaveDiff under different configurations.
Clean up to plot file naming command & missing doc strings