Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new October 2022 devices to devicelist. #3618

Merged

Conversation

Zandor300
Copy link
Contributor

Add new devices that were announced/released in October 2022:

  • iPad (10th generation)
  • iPad Pro (11-inch) (4th generation)
  • iPad Pro (12.9-inch) (6th generation)

Also fixed "iPad Pro (11-inch) (3rd generation)" being reported as "5th generation".

Also changed Apple TV naming:

  • Renamed "Apple TV (4th generation)" to "Apple TV HD".
  • Replaced "2G" naming scheme to "2nd generation"

@Zandor300
Copy link
Contributor Author

The current devicelist for Apple devices is a bit messy, with different naming schemes for different devices. Some devices are separated by whether they have cellular or not and others aren't.

I think this could be cleaned up a bit by going through all devices and correcting the naming scheme. In this case, I would suggest the naming scheme that I used in the PR description. This is the naming scheme used by Apple:

  • iPad (10th generation)
  • iPad Pro (11-inch) (4th generation)
  • iPad Pro (12.9-inch) (6th generation)

Additionally, I think the cellular specification should be dropped from the devicelist and this should be its own metric that Countly keeps track of. Countly already keeps track of the carrier the user is using anyway.

I would volunteer to do this, but maybe renaming previously added devices is discouraged? What do you think?

Also opened issue #3619 for this.

@ar2rsawseen ar2rsawseen merged commit c85bdca into Countly:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants