Update test_parser.py #139
Conversation
1.Anticipated AST: A. For the condition "(a > 1)," the test anticipates a "IfNode" with a "BinaryOpNode," followed by a body that includes the "doSomething()" function call (represented as a "FunctionCallNode"). B. The else if block is handled recursively as an additional "IfNode," including a function call ( "doSomethingElse()") and its own condition "(a < 0)". C. The function call for "fallback()" is contained in the else block. 2. Assistance Nodes: A. To compare nodes in the test, the "IfNode," "BinaryOpNode," "VariableNode," and "FunctionCallNode" classes are defined with "__eq__" methods. B. The structure that your parser outputs must match these nodes. 3. FunctionCallNode: This node symbolises a call to a function, such as "fallback()" or "doSomething()." If your parser generates a different structure for function calls, you should modify this node definition. Make that the 'IfNode,' 'BinaryOpNode,' and 'VariableNode' are generated appropriately and that your 'GLSLParser' can construct 'FunctionCallNode' objects for function calls. After you're satisfied the parser is operating correctly run the test using: python -m unittest test_glsl_parser.py
for more information, see https://pre-commit.ci
|
hii @Sambit712 it's great that you have worked on this but as of now we are do not adding the assert for all node in parser bcz it is too complicated to write assert for each node. currently there are short test example but if you write a complete code for a shader than it has so many nodes in ast writing assert for each node is very difficult. we have a different pipeline that check that example in more detail in developing stage. we are not doing the way you write this . |
|
you can checkout this #89 todo list and assign yourself a task that you feel confident and start working on it . |
|
Sir may I check out this problem or should I try adding the tests?
…On Fri, 6 Sept, 2024, 12:02 samunder singh, ***@***.***> wrote:
you can checkout this #89 <#89>
todo list and assign yourself a task that you feel confident and start
working on it .
—
Reply to this email directly, view it on GitHub
<#139 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A34NDDKQHCDAJDOAXS57PD3ZVFEBLAVCNFSM6AAAAABNXNB4VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGM2DGMBRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
hii @Sambit712 if you go through this merged PR #104 then you will understand how to add the tests not like you added . and make a single PR so i can understand what you are working on . |
1.Anticipated AST:
A. For the condition "(a > 1)," the test anticipates a "IfNode" with a "BinaryOpNode," followed by a body that includes the "doSomething()" function call (represented as a "FunctionCallNode"). B. The else if block is handled recursively as an additional "IfNode," including a function call ( "doSomethingElse()") and its own condition "(a < 0)". C. The function call for "fallback()" is contained in the else block.
A. To compare nodes in the test, the "IfNode," "BinaryOpNode," "VariableNode," and "FunctionCallNode" classes are defined with "eq" methods. B. The structure that your parser outputs must match these nodes.
This node symbolises a call to a function, such as "fallback()" or "doSomething()." If your parser generates a different structure for function calls, you should modify this node definition.
Make that the 'IfNode,' 'BinaryOpNode,' and 'VariableNode' are generated appropriately and that your 'GLSLParser' can construct 'FunctionCallNode' objects for function calls.
After you're satisfied the parser is operating correctly run the test using: python -m unittest test_glsl_parser.py
PR Description
Related Issue
shader Sample
Checklist