Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BITWISE_OR operator support in lexer and parser #209

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Add BITWISE_OR operator support in lexer and parser #209

merged 5 commits into from
Oct 28, 2024

Conversation

anshikavashistha
Copy link
Contributor

@anshikavashistha anshikavashistha commented Oct 28, 2024 •
edited by samthakur587
Loading

PR Description

Add BITWISE_OR operator support in lexer and parser

Related Issue

close #179

shader Sample

Checklist

  • Have you added the necessary tests?
  • Only modified the files mentioned in the related issue(s)?
  • Are all tests passing?

@anshikavashistha
Copy link
Contributor Author

@samthakur587 PTAL

@samthakur587 samthakur587 added enhancement New feature or request Directx backend issue at directx backend hacktoberfest labels Oct 28, 2024
samthakur587
samthakur587 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@samthakur587 samthakur587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

thanks for contributing

@samthakur587 samthakur587 merged commit b118ab8 into CrossGL:main Oct 28, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samthakur587 samthakur587 samthakur587 approved these changes

@vaatsalya123 vaatsalya123 Awaiting requested review from vaatsalya123 vaatsalya123 is a code owner

Assignees
No one assigned
Labels
Directx backend issue at directx backend enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BITWISE_OR : |
2 participants
@anshikavashistha @samthakur587