Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws): add missing arn for govcloud support #174

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix(aws): add missing arn for govcloud support #174

merged 2 commits into from
Dec 5, 2023

Conversation

carlosmmatos
Copy link
Contributor

Issue with incorrect ARN being used in manifest payload for govcloud region.

@carlosmmatos carlosmmatos added the bugfixes Fixes issues found in code label Dec 4, 2023
@carlosmmatos carlosmmatos self-assigned this Dec 4, 2023
ryanjpayne
ryanjpayne reviewed Dec 4, 2023
View reviewed changes
Copy link

@ryanjpayne ryanjpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to add region flag for boto3 calls when in govcloud

@ryanjpayne
Copy link

LGTM

@carlosmmatos carlosmmatos merged commit 26d2d82 into CrowdStrike:main Dec 5, 2023
6 checks passed
@carlosmmatos carlosmmatos deleted the aws-gov-payload-fix branch December 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjpayne ryanjpayne ryanjpayne left review comments

Assignees

@carlosmmatos carlosmmatos

Labels
bugfixes Fixes issues found in code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosmmatos @ryanjpayne