Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: convert to mv3 🎉 #53

Merged
merged 45 commits into from
Jan 9, 2023
Merged

feature: convert to mv3 🎉 #53

merged 45 commits into from
Jan 9, 2023

Conversation

0xisk
Copy link
Member

@0xisk 0xisk commented Dec 23, 2022 •
edited
Loading

Explanation

  • Converting to MV3.

More Information

  1. Fixes Update Manifest to V3 #31
  2. Fixes Converting MetamaskService from the backgorund to a sepearte service for the UI #52
  3. Fixes Importing rln.js to integreate with RLN #42
  4. Fixes Encrypting Identities #54
  5. Fixes Update React / other dependencies #41
  6. Fixes import @rln.js package #49
  7. Fixes Convert browser.* APIs to chrome.* APIs #50
  8. Fixes Github fork issue #39
  9. Fixes Build: Appear the account address in the UI #17
  10. Fixes Replace @zk-kit/identity package #47
  11. Fixes Import @semaphore/ packages #48
  12. Fixes Replace @zk-kit/protocols package #44
  13. Fixes Enhance: "Add Identity" select list colors #4
  14. Fixes Build: Adding "Delete" option in the "..." Account settings button #15
  15. Fixes Enhance: "Add Identity" user output steps #5
  16. Fixes fix: "Add Identity" sign bug #21
  17. Fixes Build: implement the "enter" button click for the "unlock" #12
  18. Fixes Fix: failed to send onMessage error #22
  19. Fixes Fix: locking the wallet after removing the browser window #20
  20. Fixes build: adding "Rename" option to the account settings #25
  21. Fixes Enhance: wallet extension logo icon #7

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

Iskander added 30 commits September 19, 2022 12:16
fix: adding metamask reference
e0c55fb
fix: adding a checker for the account before creating an identity
bab21d8
fix: enhancing the locking of the wallet after closing or removing th…
cfb7a9f 
…e browser
build: supporting Enter clicking
a8185b3
fix: fixing the connecting using ethers.js, and fixing the signing of…
6451468 
… the message in adding a new identity
fix: trying to enhance the connection with metamask
8bf3fda
fix: fixing the color of the dropdown menu, and adding the setting of…
5d17533 
… the identity metadata name settings
build: finish building the rename and delete buttons
8dbd63d
build: implementing the rename input field
9f29d41
build: implementing a rename function
ad32b49
build: trying to work on the keypress event
4cdc4f7
fix: changing to crypt-keeper name
3183a27
build: converting to V3
cdea029
fix: fixing manifest V3 permissions
e3dd0f5
fix: trying to fix Uncaught ReferenceError: Worker is not defined
ca26a3f
fix: solving this issue https://stackoverflow.com/q/74304150/13072332`
05a2411 
but its not the best way still, we need to use `importScripts()` better.

fix: removing unneeded packages for now `circomlibjs` and `ffjavascript`
fix: resolving errors in webpack
76e2790
fix: disaable zlib, and constants
46b294b
fix: resolve redux error `TS2345: Argument of type '(dispatch: Dispat…
aebdcda 
…ch) => Promise<void>' is not assignable to parameter of type 'AnyAction'`
fix: TS2305: Module '"react-router"' has no exported member 'Switch'
9321232
fix: TS2724: '"react-router"' has no exported member named 'Redirect'…
b7f37d5 
…. Did you mean 'redirect'?
fix:
afe4b86 
1. ERROR in src/background/services/protocols/semaphore.ts(65,89)
      TS2345: Argument of type 'SemaphoreFullProof' is not assignable to parameter of type 'Proof'.
  Type 'SemaphoreFullProof' is missing the following properties from type 'Proof': pi_a, pi_b, pi_c, protocol, curve

2. ERROR in src/background/services/protocols/semaphore.ts(51,21)
      TS2554: Expected 4 arguments, but got 5.

3. ERROR in src/background/services/protocols/semaphore.ts(7,5)
      TS2305: Module '"@zk-kit/protocols"' has no exported member 'genSignalHash'.

4. ERROR in src/background/services/protocols/rln.ts(42,21)
      TS2554: Expected 4 arguments, but got 5.
fix: replacing ZkIdentity from @zk-kit/identity to Identity fro…
3a1b5f7 
…m `@semaphore-protocol/identity`
fix: using MerkleProof from @zk-kit/incremental-merkle-tree and w…
5dd1db2 
…orking on removing `@zk-kit/protocols`
fix: replacing @zk-kit/protocols with @semaphore-protocol/proof a…
2e47491 
…nd `@semaphore-protocol/identity`
fix:
5c8e08e 
- Removing `@zk-kit/protocols` and `@zk-kit/identity`
- Importing `@semaphore-protocol/identity` and `rlnjs`
- Fixing main Readme typo
- Importing `@semaphore-protocol/group` and `@zk-kit/incremental-merkle-tree`
fix: trying to resolve `Could not establish connection. Receiving end…
f4e4601 
… does not exist.`
fix:
ff2ada3 
- Trying to temporary overcome eval() csp issue by running clean.sh after compiling.
- fixing webpack issue

build:
- Updating all packages in package.json including react.js to v18
fix: replacing browser with chrome
bde27a8
fix: a workaround to make browser.* apis from "webextension-polyfil…
412e90b 
…l" work
Iskander added 13 commits December 6, 2022 18:03
build: moving MetaMask class connection to the UI away from Backgroun…
7c3bd44 
…d page.
bulid: implementing a web3-provider pacakge for providing Metamask an…
196ee6e 
…d ether.js services.

fix: trying to fix createIdentity() function
fix: integrating a workaround from MetaMask extension to allow the UI…
b7135d2 
… to keep the connection with the background script.
fix: enhanding the identity factory from the background script
2e273f9
fix: enhancing the identity creation from the UI
cc3ec8c
build: implementing a seperate hooks for dealing with MetaMask, Ident…
7e6ba26 
…ityFactory, and Redux
fix: implementing a presistant storage state.
e82a738
fix: fixing delete identities
457577d
fix: fixing rename identity
7e9a5a6
fix: fixing fontawesome icons
1be9e5a
fix: encrypting identities
c7597fc
fix: integrating rlnjs refactor v2
20af5af
fix: metamask connection service
dba9d94
@0xisk 0xisk self-assigned this Dec 23, 2022
@0xisk 0xisk added 🌱 new feature Troubleshooting new feature issues 🚀 release Troubleshooting releasing issues labels Dec 23, 2022
@0xisk 0xisk added this to the Successful Beta Release milestone Dec 23, 2022
@0xisk 0xisk linked an issue Dec 23, 2022 that may be closed by this pull request
Encrypting Identities #54
Closed
AtHeartEngineer
AtHeartEngineer approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@AtHeartEngineer AtHeartEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! I'm seeing some UI spacing problems, but functionality-wise its working, so I think we should publish this as a beta version and start getting feedback.

@0xisk 0xisk merged commit 089334a into master Jan 9, 2023
@0xmad 0xmad deleted the feature/convert-mv3 branch February 21, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtHeartEngineer AtHeartEngineer AtHeartEngineer approved these changes

Assignees

@0xisk 0xisk

Labels
🌱 new feature Troubleshooting new feature issues 🚀 release Troubleshooting releasing issues
Projects
None yet
Milestone
v0.1.0-beta
2 participants
@0xisk @AtHeartEngineer