Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ms sans serif fonts 추가 #3

Merged
merged 1 commit into from
Apr 27, 2024
Merged

ms sans serif fonts 추가 #3

merged 1 commit into from
Apr 27, 2024

Conversation

joohaem
Copy link
Contributor

@joohaem joohaem commented Apr 27, 2024 •
edited
Loading

Story

  1. react95 모듈 내에 내장되어 있는 폰트에 ms sans serif 폰트가 있었음
  2. 고전 글꼴체에 어울린다 싶음. (이전에 찾아보던 싸이월드 폰트랑 고민하다가, 상관 없겠다 싶음)
  3. 모듈 내의 폰트를 사용하고 싶었는데(사용방법 리드미), next에 대해 지원을 안함 이슈 식별(Update README for NextJS Apps react95-io/React95#371) 및 해결 오리무중 상태
  4. 일단 woff2 파일 가져와서 local font로 해두었는데, 모듈 내의 글꼴을 사용할 수 있으면 가장 좋은 방법일 것 같음.

Tekiter
Tekiter approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@Tekiter Tekiter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 다른 weight 용 or 한글용 폴백 폰트들도 추가하면 될 것 같네용

@joohaem joohaem added this pull request to the merge queue Apr 27, 2024
@joohaem
Copy link
Contributor Author

joohaem commented Apr 27, 2024

@euijinkk 더 의견 주면 반영할게요 !!~

Merged via the queue into main with commit 56f11aa Apr 27, 2024
@joohaem joohaem self-assigned this Apr 28, 2024
@euijinkk
Copy link
Contributor

400, 600 밖에 없군요.
👍 고생하셨습니다!

@joohaem joohaem deleted the font branch May 1, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tekiter Tekiter Tekiter approved these changes

@euijinkk euijinkk Awaiting requested review from euijinkk

Assignees

@joohaem joohaem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joohaem @euijinkk @Tekiter