Merge dev

aderyn/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aderyn"
-version = "0.3.0"
+version = "0.3.2"
 edition = "2021"
 authors = ["Cyfrin <[email protected]>"]
 description = "Rust based Solidity AST analyzer"
@@ -10,7 +10,7 @@ default-run = "aderyn"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-aderyn_driver = { path  = "../aderyn_driver", version = "0.3.0" }
+aderyn_driver = { path  = "../aderyn_driver", version = "0.3.2" }
 clap = { version = "4.4.6", features = ["derive"] }
 reqwest = { version = "0.12.2", default-features = false, features = ["blocking", "json", "rustls-tls"] }
 semver = "1.0.22"

aderyn_core/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aderyn_core"
-version = "0.3.0"
+version = "0.3.2"
 edition = "2021"
 authors = ["Cyfrin <[email protected]>"]
 description = "Rust based Solidity AST analyzer backend"

aderyn_core/src/detect/detector.rs

@@ -120,7 +120,7 @@ pub(crate) enum IssueDetectorNamePool {
     IncorrectUseOfModifier,
     EmitAfterExternalCall,
     StateChangeAfterExternalCall,
-    StateVariableCouldBeDeclaredImmutable,
+    StateVariableCouldBeImmutable,
     MultiplePlaceholders,
     StateVariableChangesWithoutEvents,
     MissingInheritance,
@@ -141,7 +141,7 @@ pub(crate) enum IssueDetectorNamePool {
     CentralizationRisk,
     SolmateSafeTransferLib,
     HashCollisionDueToAbiEncodePacked,
-    SignatureMalleabilityDueToRawEcrecover,
+    RawEcrecover,
     DeprecatedOzFunctions,
     UnsafeERC20Functions,
     UnspecificSolidityPragma,
@@ -189,7 +189,7 @@ pub(crate) enum IssueDetectorNamePool {
     UncheckedReturn,
     DangerousUnaryOperator,
     TautologyOrContradiction,
-    DangerousStrictEquailtyOnContractBalance,
+    StrictEquailtyCheckOnContractBalance,
     SignedStorageArray,
     RedundantStatements,
     PublicVariableReadInExternalContext,
@@ -207,7 +207,7 @@ pub(crate) enum IssueDetectorNamePool {
     UninitializedLocalVariable,
     ReturnBomb,
     OutOfOrderRetryable,
-    StateVariableCouldBeDeclaredConstant,
+    StateVariableCouldBeConstant,
     // NOTE: `Undecided` will be the default name (for new bots).
     // If it's accepted, a new variant will be added to this enum before normalizing it in aderyn
     Undecided,
@@ -226,7 +226,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         IssueDetectorNamePool::IncorrectUseOfModifier => {
             Some(Box::<IncorrectUseOfModifierDetector>::default())
         }
-        IssueDetectorNamePool::StateVariableCouldBeDeclaredImmutable => {
+        IssueDetectorNamePool::StateVariableCouldBeImmutable => {
             Some(Box::<StateVariableCouldBeImmutableDetector>::default())
         }
         IssueDetectorNamePool::MultiplePlaceholders => {
@@ -243,7 +243,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         }
         IssueDetectorNamePool::UnusedImport => Some(Box::<UnusedImportDetector>::default()),
         IssueDetectorNamePool::VoidConstructor => Some(Box::<VoidConstructorDetector>::default()),
-        IssueDetectorNamePool::StateVariableCouldBeDeclaredConstant => {
+        IssueDetectorNamePool::StateVariableCouldBeConstant => {
             Some(Box::<StateVariableCouldBeConstantDetector>::default())
         }
         IssueDetectorNamePool::LiteralInsteadOfConstant => {
@@ -302,9 +302,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         IssueDetectorNamePool::HashCollisionDueToAbiEncodePacked => {
             Some(Box::<AvoidAbiEncodePackedDetector>::default())
         }
-        IssueDetectorNamePool::SignatureMalleabilityDueToRawEcrecover => {
-            Some(Box::<EcrecoverDetector>::default())
-        }
+        IssueDetectorNamePool::RawEcrecover => Some(Box::<EcrecoverDetector>::default()),
         IssueDetectorNamePool::DeprecatedOzFunctions => {
             Some(Box::<DeprecatedOZFunctionsDetector>::default())
         }
@@ -421,7 +419,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         IssueDetectorNamePool::TautologyOrContradiction => {
             Some(Box::<TautologyOrContraditionDetector>::default())
         }
-        IssueDetectorNamePool::DangerousStrictEquailtyOnContractBalance => {
+        IssueDetectorNamePool::StrictEquailtyCheckOnContractBalance => {
             Some(Box::<DangerousStrictEqualityOnBalanceDetector>::default())
         }
         IssueDetectorNamePool::SignedStorageArray => {

aderyn_core/src/detect/high/dangerous_strict_equality_balance.rs

@@ -73,7 +73,7 @@ impl IssueDetector for DangerousStrictEqualityOnBalanceDetector {
     }
 
     fn name(&self) -> String {
-        IssueDetectorNamePool::DangerousStrictEquailtyOnContractBalance.to_string()
+        IssueDetectorNamePool::StrictEquailtyCheckOnContractBalance.to_string()
     }
 }
 

aderyn_core/src/detect/low/ecrecover.rs

@@ -49,7 +49,7 @@ impl IssueDetector for EcrecoverDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::SignatureMalleabilityDueToRawEcrecover)
+        format!("{}", IssueDetectorNamePool::RawEcrecover)
     }
 }
 

aderyn_core/src/detect/low/state_variable_could_be_constant.rs

@@ -106,7 +106,7 @@ impl IssueDetector for StateVariableCouldBeConstantDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::StateVariableCouldBeDeclaredConstant)
+        format!("{}", IssueDetectorNamePool::StateVariableCouldBeConstant)
     }
 }
 

aderyn_core/src/detect/low/state_variable_could_be_immutable.rs

@@ -148,7 +148,7 @@ impl IssueDetector for StateVariableCouldBeImmutableDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::StateVariableCouldBeDeclaredImmutable)
+        format!("{}", IssueDetectorNamePool::StateVariableCouldBeImmutable)
     }
 }
 

aderyn_driver/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aderyn_driver"
-version = "0.3.0"
+version = "0.3.2"
 edition = "2021"
 authors = ["Cyfrin <[email protected]>"]
 description = "Rust based Solidity AST analyzer driver"
@@ -9,7 +9,7 @@ license = "MIT"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-aderyn_core = { path  = "../aderyn_core", version = "0.3.0" }
+aderyn_core = { path  = "../aderyn_core", version = "0.3.2" }
 rayon = "1.8.0"
 cyfrin-foundry-compilers = { version = "0.3.20-aderyn", features = ["svm-solc"]   }
 serde_json = { version = "1.0.96", features = ["preserve_order"] }

aderyn_py/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aderyn_py"
-version = "0.3.0"
+version = "0.3.2"
 edition = "2021"
 authors = ["Cyfrin <[email protected]>"]
 description = "Rust based Solidity AST analyzer python bindings"
@@ -14,10 +14,10 @@ name = "aderynpy"
 crate-type = ["cdylib"]
 
 [dependencies]
-aderyn_driver = { path  = "../aderyn_driver", version = "0.3.0" }
+aderyn_driver = { path  = "../aderyn_driver", version = "0.3.2" }
 field_access = "0.1.8"
 
 [dependencies.pyo3]
 version = "0.22.2"
 # "abi3-py38" tells pyo3 (and maturin) to build using the stable ABI with minimum Python version 3.8
-features = ["abi3-py38"]
+features = ["abi3-py38"]