removed erc165 thing

Cyfrin · Aug 12, 2024 · 73487b8 · 73487b8
1 parent 54f57e3
commit 73487b8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 30 deletions.
diff --git a/aderyn_core/src/detect/high/incorrect_erc721_interface.rs b/aderyn_core/src/detect/high/incorrect_erc721_interface.rs
@@ -81,9 +81,7 @@ impl IssueDetector for IncorrectERC721InterfaceDetector {
                                 capture!(self, context, func);
                             }
 
-                            if (func.represents_erc721_is_approved_for_all()
-                                || func.represents_erc165_supports_interface())
-                                && !func.returns_bool()
+                            if func.represents_erc721_is_approved_for_all() && !func.returns_bool()
                             {
                                 capture!(self, context, func);
                             }
@@ -233,14 +231,6 @@ mod erc721_matching_function_signature_helper {
             };
             satisfier.satisfies(self)
         }
-
-        pub fn represents_erc165_supports_interface(&self) -> bool {
-            let satisifer = SignatureMatcher {
-                name: "supportsInterface",
-                paramter_types: vec!["bytes4"],
-            };
-            satisifer.satisfies(self)
-        }
     }
 
     // Helpers to match return types (bool & uint256)
@@ -308,7 +298,7 @@ mod incorrect_erc721_tests {
         assert!(found);
         // assert that the detector found the correct number of instances
 
-        assert_eq!(detector.instances().len(), 9);
+        assert_eq!(detector.instances().len(), 8);
 
         // assert the severity is high
         assert_eq!(

diff --git a/tests/contract-playground/src/IncorrectERC721.sol b/tests/contract-playground/src/IncorrectERC721.sol
@@ -96,15 +96,6 @@ contract IncorrectERC721 {
         balances[to] += 1;
         totalSupply += 1;
     }
-
-    // Define the ERC-165 identifier for the ERC-165 interface itself
-    bytes4 private constant _INTERFACE_ID_ERC165 = 0x01ffc9a7;
-
-    function supportsInterface(
-        bytes4 interfaceId
-    ) external view virtual returns (address) {
-        return address(0x1);
-    }
 }
 
 interface MyIERC721 {
@@ -282,15 +273,6 @@ contract CorrectERC721 is MyIERC721 {
             getApproved(tokenId) == spender ||
             isApprovedForAll(owner, spender));
     }
-
-    // Define the ERC-165 identifier for the ERC-165 interface itself
-    bytes4 private constant _INTERFACE_ID_ERC165 = 0x01ffc9a7;
-
-    function supportsInterface(
-        bytes4 interfaceId
-    ) external view virtual returns (bool) {
-        return interfaceId == _INTERFACE_ID_ERC165;
-    }
 }
 
 interface IERC721Receiver {