Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This code fails when T is polymorphic #268

Open
lifflander opened this issue Oct 27, 2022 · 2 comments · May be fixed by #362
Open

This code fails when T is polymorphic #268

lifflander opened this issue Oct 27, 2022 · 2 comments · May be fixed by #362
Assignees

Comments

@lifflander
Copy link
Contributor

std::unique_ptr<T> task(new U(1234));
auto ret = checkpoint::serialize<T>(*task);
auto out = checkpoint::deserialize<T>(std::move(ret));

@PhilMiller What do you think? Should we support this case?

@nlslatt

@PhilMiller
Copy link
Member

Yes, I think we should support this case. It presumably works fine if task is serialized as a member of something else, and it's just s | task?

@PhilMiller
Copy link
Member

Since a PR for this just got posted, I'm looking at the example again, and I can't help but read that as kinda like slicing. Probably still good if it is made to work correctly, though. I'll look at the PR.

thearusable added a commit that referenced this issue Jul 24, 2024
thearusable added a commit that referenced this issue Sep 24, 2024
thearusable added a commit that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants