#268: Fix deserialization of polymorphic types when base class is specified as a template parameter. #362
+247
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thearusable
force-pushed
the
268-deserialize-polymorphic-type
branch
from
842ae6f
to
32264fe
Compare
PhilMiller
reviewed
Jul 23, 2024
PhilMiller
reviewed
Jul 23, 2024
|
I'll wait to look deeper at the implementation until the tests are passing. |
thearusable
requested review from
lifflander,
cz4rs,
nmm0,
JacobDomagala and
PhilMiller
thearusable
changed the title
thearusable
force-pushed
the
268-deserialize-polymorphic-type
branch
from
4c4027c
to
9c50fab
Compare
lifflander
requested changes
Sep 24, 2024
| auto ret = checkpoint::serialize(*task); | ||
| auto out = checkpoint::deserialize<Base>(std::move(ret)); | ||
|
|
||
| EXPECT_TRUE(nullptr != out); |
There was a problem hiding this comment.
I think we should probably include an ID check here to ensure we are getting the right type instead of just checking that it's not null and the output value is correct.
There was a problem hiding this comment.
I added the check for typeid.
…ith/without serialization error checking
thearusable
force-pushed
the
268-deserialize-polymorphic-type
branch
from
9bd0905
to
6fec221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268