Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This code fails when T is polymorphic #268

Open
lifflander opened this issue Oct 27, 2022 · 2 comments · May be fixed by #362
Open

This code fails when T is polymorphic #268

lifflander opened this issue Oct 27, 2022 · 2 comments · May be fixed by #362
Assignees
@thearusable

Comments

@lifflander
Copy link
Contributor 

std::unique_ptr<T> task(new U(1234));
auto ret = checkpoint::serialize<T>(*task);
auto out = checkpoint::deserialize<T>(std::move(ret));

@PhilMiller What do you think? Should we support this case?

@nlslatt
@PhilMiller
Copy link
Member

Yes, I think we should support this case. It presumably works fine if task is serialized as a member of something else, and it's just s | task?

thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add tests for deserialization of the polymorphic types
5b7d1fd
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add support for deserialization when called from the base type
85e0597
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add comments in the deserializeType method
7b83558
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Remove logs
842ae6f
@thearusable thearusable linked a pull request Jul 23, 2024 that will close this issue
Open
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add tests for deserialization of the polymorphic types
62a52de
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add support for deserialization when called from the base type
eb6f507
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add comments in the deserializeType method
a8db884
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Remove default parameters from Prefixed::unpack method
32264fe
thearusable added a commit that referenced this issue Jul 23, 2024
@thearusable
#268: Add prefix validation to protect against requests with invalid …
18d8eb4 
…types
@PhilMiller
Copy link
Member

Since a PR for this just got posted, I'm looking at the example again, and I can't help but read that as kinda like slicing. Probably still good if it is made to work correctly, though. I'll look at the PR.

thearusable added a commit that referenced this issue Jul 24, 2024
@thearusable
#268: Refactor dispatcher to properly deserialize polymorphic types w…
1cbcf88 
…ith/without serialization error checking
thearusable added a commit that referenced this issue Jul 24, 2024
@thearusable
#268: Add check for type id in virtual serialize tests
b1df9b0
thearusable added a commit that referenced this issue Jul 24, 2024
@thearusable
#268: Add validate parameter to all constructors in Unpacker
965d678
thearusable added a commit that referenced this issue Jul 24, 2024
@thearusable
#268: Add check for type id in virtual serialize test
2fd3b6f
thearusable added a commit that referenced this issue Jul 24, 2024
@thearusable
#268: Move delete to the bottom of deserializeType function
f6b5705
thearusable added a commit that referenced this issue Jul 30, 2024
@thearusable
#268: Remove the need for the second pass when deserializing a polymo…
c479be3 
…rphic type
thearusable added a commit that referenced this issue Jul 30, 2024
@thearusable
#268: Remove validate_memory_ member from UnpackerBuffer
4c4027c
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add tests for deserialization of the polymorphic types
0fb2e1b
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add support for deserialization when called from the base type
4962d6b
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add comments in the deserializeType method
680cfb3
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Remove default parameters from Prefixed::unpack method
62517d2
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add prefix validation to protect against requests with invalid …
dfaf97f 
…types
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Refactor dispatcher to properly deserialize polymorphic types w…
ffc3644 
…ith/without serialization error checking
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add check for type id in virtual serialize tests
a785956
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add validate parameter to all constructors in Unpacker
2c7c4bd
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Add check for type id in virtual serialize test
c91d71b
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Move delete to the bottom of deserializeType function
330c047
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Remove the need for the second pass when deserializing a polymo…
a068166 
…rphic type
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Remove validate_memory_ member from UnpackerBuffer
9c50fab
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#268: Update license in the test_polymorphic file
bcddb46
thearusable added a commit that referenced this issue Sep 25, 2024
@thearusable
#268: Add check for type ID in tests for polymorphic types
9bd0905
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add tests for deserialization of the polymorphic types
bba1f26
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add support for deserialization when called from the base type
2927fc3
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add comments in the deserializeType method
d1a6d6c
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Remove default parameters from Prefixed::unpack method
de50583
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add prefix validation to protect against requests with invalid …
57a77ba 
…types
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Refactor dispatcher to properly deserialize polymorphic types w…
0aab792 
…ith/without serialization error checking
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add check for type id in virtual serialize tests
468af6a
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add validate parameter to all constructors in Unpacker
a2e7abe
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add check for type id in virtual serialize test
35e050c
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Move delete to the bottom of deserializeType function
7f78f73
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Remove the need for the second pass when deserializing a polymo…
148b93c 
…rphic type
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Remove validate_memory_ member from UnpackerBuffer
03df7fa
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Update license in the test_polymorphic file
639fea0
thearusable added a commit that referenced this issue Sep 30, 2024
@thearusable
#268: Add check for type ID in tests for polymorphic types
6fec221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PhilMiller @lifflander @thearusable