Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#260: Add alias namespace #339

Merged
merged 2 commits into from
May 28, 2024
Merged

#260: Add alias namespace #339

merged 2 commits into from
May 28, 2024

Conversation

thearusable
Copy link
Contributor

Closes #260

@thearusable thearusable self-assigned this May 20, 2024
@thearusable thearusable marked this pull request as ready for review May 20, 2024 15:06
cz4rs
cz4rs approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

lifflander
lifflander reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add the alias the other way around.

@thearusable
Copy link
Contributor Author

I updated the implementation to not change the name of checkpoint namespace. I needed to rename the magistrate namespace in examples.

@lifflander lifflander merged commit c985084 into develop May 28, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias namespace to magistrate
3 participants
@thearusable @lifflander @cz4rs