#2286: Remove `gcc-8` support #2360

thearusable · 2024-09-30T14:12:54Z

github-actions · 2024-09-30T16:18:49Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 6b623be (2024-11-14 16:15:04 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-10, ubuntu, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 11c64cf (2024-11-15 15:18:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 11c64cf (2024-11-15 15:18:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for f2bcaea (2024-11-15 17:08:06 UTC)

Compilation - successful

Testing - passed

Build log

cz4rs · 2024-11-15T10:15:13Z

gcc9 + zoltan build has a couple of following:
##[warning]Free memory is lower than 5%; Currently used: 96.92%

~~This actually causes the build to fail even though compilation and tests complete fine. Investigating.~~
Build is failing during JSON validation:

+ /vt/scripts/check_lb_data_files.sh /build/vt /vt
Validating schema of json files...
INFO - JSON_data_files_validator.py:390 - Validating file: /build/vt/tests/vt_lb_data/data.1.json.br
Traceback (most recent call last):
  File "/vt/scripts/JSON_data_files_validator.py", line 478, in <module>
    JSONDataFilesValidator().main()
  File "/vt/scripts/JSON_data_files_validator.py", line 458, in main
    self.__validate_file(file_path=self.__file_path)
  File "/vt/scripts/JSON_data_files_validator.py", line 403, in __validate_file
    if SchemaValidator(schema_type=schema_type).is_valid(schema_to_validate=json_data):
  File "/vt/scripts/JSON_data_files_validator.py", line 285, in is_valid
    is_valid = self.valid_schema.is_valid(schema_to_validate)
AttributeError: 'Schema' object has no attribute 'is_valid'

Use a build based on Ubuntu 24.04 to ensure recent versions of Python dependencies (python3-schema).

thearusable self-assigned this Sep 30, 2024

thearusable force-pushed the 2286-remove-gcc-8-support branch from f09015f to a076496 Compare September 30, 2024 16:29

cz4rs marked this pull request as ready for review November 14, 2024 16:13

thearusable added 9 commits November 14, 2024 17:14

#2286: Remove gcc-8 references

97a9a03

#2286: Remove std::filesystem workaround for gcc-8

21c1e64

#2286: Replace old gcc-8 address sanitizer CI with gcc-13

bc1f86a

#2286: Remove workaround in code for gcc-8

c5a66f7

#2286: Remove warnings during perf tests compilation

bb22804

#2286: Update ubuntu version for new CI to 24.04

2b6a555

#2268: Fix installation of python packages on newer versions of ubuntu

53a7cee

#2268: Update gcc-8 references

b0d4f48

#2268: Move gcc-13 pipeline definition to be in order

6b623be

cz4rs force-pushed the 2286-remove-gcc-8-support branch from a076496 to 6b623be Compare November 14, 2024 16:15

cz4rs force-pushed the 2286-remove-gcc-8-support branch from b90781b to a559fe2 Compare November 15, 2024 12:41

cz4rs added 3 commits November 15, 2024 16:18

#2268: ignore invalid maybe-uninitialized warning

3af8c4f

#2268: move JSON validation to clang-16 build

affd1e4

Use a build based on Ubuntu 24.04 to ensure recent versions of Python dependencies (python3-schema).

#2268: remove gcc-8 badge from README

11c64cf

cz4rs force-pushed the 2286-remove-gcc-8-support branch from a559fe2 to 11c64cf Compare November 15, 2024 15:18

#2286: do not use cache when building docker images

f2bcaea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2286: Remove `gcc-8` support #2360

#2286: Remove `gcc-8` support #2360

thearusable commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 •

edited

Loading

cz4rs commented Nov 15, 2024 •

edited

Loading

#2286: Remove gcc-8 support #2360

Are you sure you want to change the base?

#2286: Remove gcc-8 support #2360

Conversation

thearusable commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 • edited Loading

Pipelines results

cz4rs commented Nov 15, 2024 • edited Loading

#2286: Remove `gcc-8` support #2360

#2286: Remove `gcc-8` support #2360

github-actions bot commented Sep 30, 2024 •

edited

Loading

cz4rs commented Nov 15, 2024 •

edited

Loading