Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resource Distributor to enable name change #1221

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

homework36
Copy link
Contributor

@homework36 homework36 commented Nov 1, 2024

Resolves: (#1190)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

Enable user specified renaming of an output within the job Resource Distributor:

  • add custom prefix and custom suffix so that the user can modify the name (to some useful extent)
  • update unit test and test successful locally

*Users should consider the file formatting themselves. For example, "custom prefix - " will lead to "custom prefix - old name" while "custom prefix" will become"custom prefixold name".

@homework36 homework36 changed the title Fix outputname Fix Resource Distributor to enable name change Nov 1, 2024
This is the default type for layers from classifying job (where the rename feature is mostly needed)
@homework36
Copy link
Contributor Author

homework36 commented Nov 4, 2024

Screenshot 2024-11-04 at 11 15 22 AM
Screenshot 2024-11-04 at 11 24 32 AM
Screenshot 2024-11-04 at 11 25 09 AM
Screenshot 2024-11-04 at 11 25 21 AM

Test for classifying with multiple inputs (forgot to add one more space before my custom suffix...

so that the user will understand they need to set the type in the job accordingly
@homework36 homework36 merged commit d65c467 into develop Nov 4, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants