Skip to content

Commit

Permalink
Remove default values for OIDC configuration
Browse files Browse the repository at this point in the history
In a [discussion on a different PR](#234 (comment)),
there was a suggestion
to remove the default values from the OIDC configuration to trigger
misconfiguration messages sooner, eg. on app startup.

The idea is that this would make development better as any
misconfiguration error would be clearer.
  • Loading branch information
felixclack committed Jul 13, 2023
1 parent 4d5dd8e commit e820b2f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions config/initializers/omniauth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
OmniAuth.config.on_failure = proc { |env| AuthFailuresController.action(:failure).call(env) }

# DSI setup
dfe_sign_in_identifier = ENV.fetch("DFE_SIGN_IN_CLIENT_ID", "example")
dfe_sign_in_secret = ENV.fetch("DFE_SIGN_IN_SECRET", "example")
dfe_sign_in_redirect_uri = ENV.fetch("DFE_SIGN_IN_REDIRECT_URL", "example")
dfe_sign_in_identifier = ENV["DFE_SIGN_IN_CLIENT_ID"]
dfe_sign_in_secret = ENV["DFE_SIGN_IN_SECRET"]
dfe_sign_in_redirect_uri = ENV["DFE_SIGN_IN_REDIRECT_URL"]
dfe_sign_in_issuer_uri = ENV["DFE_SIGN_IN_ISSUER"].present? ? URI(ENV["DFE_SIGN_IN_ISSUER"]) : nil
options = {
name: :dfe,
Expand Down Expand Up @@ -41,7 +41,7 @@
# Identity setup
Rails.application.config.middleware.use OmniAuth::Builder do
provider :identity,
ENV.fetch("IDENTITY_CLIENT_ID"),
ENV.fetch("IDENTITY_CLIENT_SECRET"),
ENV["IDENTITY_CLIENT_ID"],
ENV["IDENTITY_CLIENT_SECRET"],
{ path_prefix: "/qualifications/users/auth" }
end

0 comments on commit e820b2f

Please sign in to comment.