updated github_actions.md

DFE-Digital · Jul 10, 2023 · 09ca92c · 09ca92c
1 parent 52f20db
commit 09ca92c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/update_application_statuses.yml b/.github/workflows/update_application_statuses.yml
@@ -1,11 +1,11 @@
-name: Schedule Update Application Statuses
+name: Update Application Statuses
 on:
   schedule:
     - cron:  '0 0 * * *'
 
 jobs:
   sweep:
-    name: Schedule Update Application Statuses
+    name: Update Application Statuses
 
     runs-on: ubuntu-20.04
     steps:
@@ -17,7 +17,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install cf7-cli
 
-      - name: Schedule Update Application Statuses for dev
+      - name: Update Application Statuses for dev
         shell: bash
         env:
           PAAS_ORGANISATION: dfe
@@ -33,7 +33,7 @@ jobs:
           cf target -o "${{ env.PAAS_ORGANISATION }}" -s "${{ env.PAAS_SPACE }}"
           cf run-task "${{ env.APP_NAME }}"-"${{ env.ENV_STUB }}" --command "cd /app && /usr/local/bundle/bin/bundle exec rails runner 'ApplicationSynchronizationJob.perform_later'" --process worker --name update_application_statuses
 
-      - name: Schedule Update Application Statuses for staging
+      - name: Update Application Statuses for staging
         shell: bash
         env:
           PAAS_ORGANISATION: dfe
@@ -49,7 +49,7 @@ jobs:
           cf target -o "${{ env.PAAS_ORGANISATION }}" -s "${{ env.PAAS_SPACE }}"
           cf run-task "${{ env.APP_NAME }}"-"${{ env.ENV_STUB }}" --command "cd /app && /usr/local/bundle/bin/bundle exec rails runner 'ApplicationSynchronizationJob.perform_later'" --process worker --name update_application_statuses
 
-      - name: Schedule Update Application Statuses for sandbox
+      - name: Update Application Statuses for sandbox
         shell: bash
         env:
           PAAS_ORGANISATION: dfe
@@ -65,7 +65,7 @@ jobs:
           cf target -o "${{ env.PAAS_ORGANISATION }}" -s "${{ env.PAAS_SPACE }}"
           cf run-task "${{ env.APP_NAME }}"-"${{ env.ENV_STUB }}" --command "cd /app && /usr/local/bundle/bin/bundle exec rails runner 'ApplicationSynchronizationJob.perform_later'" --process worker --name update_application_statuses
 
-      - name: Schedule Update Application Statuses for prod
+      - name: Update Application Statuses for prod
         shell: bash
         env:
           PAAS_ORGANISATION: dfe

diff --git a/app/lib/services/ecf/ecf_application_synchronization.rb b/app/lib/services/ecf/ecf_application_synchronization.rb
@@ -36,12 +36,8 @@ def handle_response(response)
             lead_provider_approval_status = record.lead_provider_approval_status
             participant_outcome_state = record.participant_outcome_state
 
-            application = Application.find_by(ecf_id: id)
-            if application.present?
-              application.update!(lead_provider_approval_status:, participant_outcome_state:)
-            else
-              raise "Application not found for ecf_id: #{id}"
-            end
+            application = Application.find_by!(ecf_id: id)
+            application.update!(lead_provider_approval_status:, participant_outcome_state:)
           end
         else
           raise "Failed to update application: #{response.message}"

diff --git a/docs/github_actions.md b/docs/github_actions.md
@@ -34,6 +34,10 @@ Runs once a day to delete stale sessions from the database.
 
 Runs on demand to update course definitions in the database. Syncing them to match `Courses::DEFINITIONS`.
 
+### Update Application Statuses ([update_application_statuses.yml](../.github/workflows/update_application_statuses.yml))
+
+Runs once a day to update applications lead_provider_approval_status and participant_outcome_state retrieved from the ecf.
+
 ### Updating Schools
 
 See [Importing schools](importing_data.md#importing-schools) for more information.