Skip to content

Commit

Permalink
fixed failing rspec
Browse files Browse the repository at this point in the history
  • Loading branch information
@javier-npq
javier-npq committed Jun 28, 2023
1 parent 1e110c5 commit 0a54b62
Show file tree
Hide file tree
Showing 29 changed files with 30 additions and 30 deletions.
2 changes: 1 addition & 1 deletion config/schedule.rb
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require File.expand_path(File.join(File.dirname(__FILE__), "..", "config", "environment"))

every 30.minutes do
every 3.hours do
runner "ApplicationSynchronizationJob.perform_now", environment: Rails.env
end
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/js/when_working_at_an_eligible_primary_school_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
"headteacher_status" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/js/while_not_currently_working_at_school_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"private_childcare_provider_urn" => nil,
"school_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion ...s/happy_journeys/js/while_working_at_private_childcare_provider_but_not_a_nursery_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
"tsf_primary_plus_eligibility" => false,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"works_in_childcare" => true,
"works_in_nursery" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/js/while_working_at_private_nursery_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
"headteacher_status" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"kind_of_nursery" => "private_nursery",
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/js/while_working_at_public_nursery_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
"headteacher_status" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"kind_of_nursery" => public_kind_of_nursery_key,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/js/while_working_in_neither_a_school_nor_childcare_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"headteacher_status" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/able_to_receive_targeted_delivery_funding_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/funded_ehco_registration_journey_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"school_urn" => "100000",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"targeted_delivery_funding_eligibility" => false,
"teacher_catchment" => "england",
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/international_teacher_npqh_journey_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"funding_choice" => "school",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "not_in_england",
"headteacher_status" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/other_funded_ehco_registration_journey_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"school_urn" => "100000",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"targeted_delivery_funding_eligibility" => false,
"teacher_catchment" => "england",
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/previously_received_targeted_delivery_funding_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/via_using_old_name_and_not_headship_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/happy_journeys/non_js/via_using_same_name_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/basic_registration_journey_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def run_scenario(js:)
"headteacher_status" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/changing_do_you_work_in_a_school_from_no_to_yes_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def run_scenario(js:)
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/changing_do_you_work_in_childcare_from_yes_to_no_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def run_scenario(js:)
"funding_choice" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "no_institution",
"headteacher_status" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/changing_from_outside_of_catchment_area_to_inside_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def run_scenario(js:)
"funding_eligiblity_status_code" => "ineligible_establishment_type",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"headteacher_status" => nil,
"kind_of_nursery" => nil,
Expand Down
2 changes: 1 addition & 1 deletion ...features/journeys/happy_paths/changing_npq_to_one_leadprovider_no_longer_supports_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def run_scenario(js:)
"funding_choice" => "school",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "ineligible_establishment_type",
"headteacher_status" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/via_using_old_name_and_not_headship_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def run_scenario(js:)
"tsf_primary_plus_eligibility" => false,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"works_in_childcare" => false,
"works_in_nursery" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/when_choose_lead_mentor_course_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def run_scenario(js:)
"works_in_school" => false,
"work_setting" => "other",
"lead_mentor" => true,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"itt_provider" => approved_itt_provider_legal_name,
"raw_application_data" => {
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/when_get_an_identity_returns_no_trn_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def run_scenario(js:)
"headteacher_status" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/when_outside_of_catchment_area_crown_dependencies_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def run_scenario(js:) # rubocop:disable Lint/UnusedMethodArgument
"school_urn" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"targeted_delivery_funding_eligibility" => false,
"teacher_catchment" => "jersey_guernsey_isle_of_man",
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/when_outside_of_catchment_area_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def run_scenario(js:)
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => LeadProvider.find_by(name: "Teach First").id,
"private_childcare_provider_urn" => nil,
Expand Down
2 changes: 1 addition & 1 deletion spec/features/journeys/happy_paths/when_previously_funded_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def run_scenario(js:)
"funding_choice" => "self",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "previously_funded",
"headteacher_status" => "yes_in_first_five_years",
Expand Down
2 changes: 1 addition & 1 deletion spec/features/sad_journeys/applying_for_ehco_but_not_new_headteacher_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"funding_choice" => "self",
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "ineligible_establishment_type",
"headteacher_status" => "yes_over_five_years",
Expand Down
2 changes: 1 addition & 1 deletion spec/features/sad_journeys/lead_mentor_journey_with_incorrect_course_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
"works_in_school" => false,
"work_setting" => "other",
"lead_mentor" => true,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"itt_provider" => approved_itt_provider_legal_name,
"raw_application_data" => {
Expand Down
2 changes: 1 addition & 1 deletion spec/features/sad_journeys/works_in_childcare_but_not_in_england_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"school_urn" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"targeted_delivery_funding_eligibility" => false,
"teacher_catchment" => "scotland",
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/services/handle_submission_for_store_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def stable_as_json(record)
"kind_of_nursery" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"lead_provider_id" => lead_provider.id,
"private_childcare_provider_urn" => nil,
Expand Down Expand Up @@ -213,7 +213,7 @@ def stable_as_json(record)
"funding_choice" => nil,
"itt_provider" => nil,
"lead_mentor" => false,
"lead_provider_approval_status" => "pending",
"lead_provider_approval_status" => nil,
"participant_outcome_state" => nil,
"funding_eligiblity_status_code" => "early_years_invalid_npq",
"headteacher_status" => nil,
Expand Down

0 comments on commit 0a54b62

Please sign in to comment.