Merge pull request #837 from DFE-Digital/CPDNPQ-1188-update-only-sync…

…ed-application-with-ecf CPDNPQ-1188: Update only synced application with ecf
DFE-Digital · Jul 12, 2023 · 1248438 · 1248438
2 parents 0502bc6 + 4b51b9e
commit 1248438
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/lib/services/ecf/ecf_application_synchronization.rb b/app/lib/services/ecf/ecf_application_synchronization.rb
@@ -36,8 +36,12 @@ def handle_response(response)
             lead_provider_approval_status = record.lead_provider_approval_status
             participant_outcome_state = record.participant_outcome_state
 
-            application = Application.find_by!(ecf_id: id)
-            application.update!(lead_provider_approval_status:, participant_outcome_state:)
+            application = Application.find_by(ecf_id: id)
+            if application.present?
+              application.update!(lead_provider_approval_status:, participant_outcome_state:)
+            else
+              Rails.logger.info("Application where ecf_id=#{id} is not synced yet")
+            end
           end
         else
           raise "Failed to update application: #{response.message}"