-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPDNQT-2152] Resend outcome to api #1822
Conversation
config/routes.rb
Outdated
@@ -234,6 +234,10 @@ | |||
resources :courses, only: %i[index show] | |||
resources :users, only: %i[index show] | |||
|
|||
resources :participant_outcomes, only: %i[] do | |||
member { get :resend } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwrw I've followed ECF and made this a GET
but it feels like this should be a POST
since its modifying data? Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea POST
sounds better tbh 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just some minor comments
QTA = Qualified Teachers API
dfc33d7
to
e9d3838
Compare
Review app deployed to https://npq-registration-review-1822-web.test.teacherservices.cloud/ |
e9d3838
to
1ab9805
Compare
Previously used when finding if declaration is latest
1ab9805
to
432f93a
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Context
Ticket: CPDNPQ-2152
We want to allow admin users to reschedule delivery of outcomes to the qualified teachers API
Changes proposed in this pull request
nil
out the relevant ParticipantOutcome attributes, which will trigger reschedulingResend
linkapplications#show
screen.Screenshots