[CPDLP-3632] Ensure school ukprn matches school urn in application migrator #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-1832-web.test.teacherservices.cloud/ |
cwrw
reviewed
Oct 20, 2024
cwrw
approved these changes
Oct 20, 2024
ethax-ross
reviewed
Oct 21, 2024
mooktakim
approved these changes
Oct 21, 2024
leandroalemao
force-pushed
the
CPDLP-3632
branch
2 times, most recently
from
b74ad17
to
e51d2ca
Compare
leandroalemao
force-pushed
the
CPDLP-3632
branch
from
e51d2ca
to
258b481
Compare
ethax-ross
approved these changes
Oct 21, 2024
…school ukprn pulled in from ECF is nil
leandroalemao
force-pushed
the
CPDLP-3632
branch
from
0282a31
to
015b1e6
Compare
leandroalemao
had a problem deploying
to
review
GitHub Actions
Failure
|
cwrw
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: CPDLP-3632
We are not checking if the school urn and school ukprn come from the same school in the migration.
Changes proposed in this pull request
Ensure that any value we pull in from ECF for school urn and school ukprn match the same school and should be aligned, otherwise raise a failure.