-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPDLP-3631] Ensure we migrate all relevant timestamps from ECF #1848
[CPDLP-3631] Ensure we migrate all relevant timestamps from ECF #1848
Conversation
3e704bc
to
feef997
Compare
cf977b7
to
68693b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just one question
@@ -25,6 +25,8 @@ class Application < Base | |||
teacher_catchment_country | |||
notes | |||
funded_place | |||
created_at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in user, are we making sure this is covered?
Overwrite updated_at with the one from ECF, or set to the date of migration if anything changed from ECF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated_at
will be set to Time.now when:
- Application
ukprn
is changed from ECF - User
trn
andemail
is changed from ECF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good with a few comments, can we also run this in migration keen to see how the parity checks look like and as discussed and how long it will take with papertrail now :)
Review app deployed to https://npq-registration-review-1848-web.test.teacherservices.cloud/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 thanks mook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good tks @mooktakim 👍
…ser timestamps replaced with ECF
d29fec4
to
ae65ecc
Compare
Quality Gate passedIssues Measures |
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDLP-3631
Changes proposed in this pull request
Cohort
,Schedule
,ParticipantIdChange
andStatement
migrations will use timestamps from ECFpaper_trail
object
field type is nowjson
object_changes
addednote
fieldApplication
&User
version_note
which addsversions.note
entry intoversions
version_note
updated_at
toTime.zone.now