-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating cookies policy #7181
Open
EllieNodder
wants to merge
8
commits into
main
Choose a base branch
from
updating-cookies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updating cookies policy #7181
+84
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review app deployed to https://teaching-vacancies-review-pr-7181.test.teacherservices.cloud on AKS |
KyleMacPherson
approved these changes
Oct 17, 2024
scruti
approved these changes
Oct 18, 2024
* origin/main: (23 commits) Rubocop govuk (#7199) Only validate models email if email changed Improve application form content (#7167) Do not validate Org when creating a Vacancy Bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2 Bump the npm-dependencies group with 4 updates (#7196) Fixing typo and content tweaks on request an account page Adding optional to flexible working question Add tag to deadline passed on saved jobs Add blank line at end of file for linting Add missing button back Fix link on preview section Fix link fix syntax errors Add link to turn on profile text tweaking copy trying to fix link Tweaking turning profile on text and adding link Bump Openssl version in docker image Bump the gem-dependencies group with 5 updates ...
Unrelated to this PR. This should be failing in "main" branch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/9tEzwEY3/1332-update-cookies-policy
Changes in this PR:
We need to update our cookies to account for VWO and Microsoft Clarity.
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?