Only validate models email if email changed #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruti
force-pushed
the
only-validate-models-email-if-changing-email
branch
from
702b9df
to
edd2995
Compare
Since we introduced the new email validation, existing objects for multiple models became invalid due to not passing the email validation. This becomes an issue as affected users get unexpected errors when trying to update those objects in different flows unrelated with introducing/updating the email. We are trying to mitigate this by only validate the email for the models if the email field has been updated (new/changed value). This would allow the object to still be valid when containing a legacy email, while not allowing to create/edit the email with an invalid value.
scruti
force-pushed
the
only-validate-models-email-if-changing-email
branch
from
edd2995
to
7131f04
Compare
starswan
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced the new email validation, existing objects for multiple models became invalid due to not passing the email validation.
This becomes an issue as affected users get unexpected errors when trying to update those objects in different flows unrelated to introducing/updating the email.
We are trying to mitigate this by only validating the models' email if the email field has been updated (new/changed value).
This would allow the object to still be valid when containing a legacy email, while not allowing to create/edit the email with an invalid value.