Restore options for precision of div/rcp/sqrt/rsqrt #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores support for SSE2NEON_PRECISE_DIV and SSE2NEON_PRECISE_SQRT with the same level of precision that they had before deprecation in DLTcollab#580. That changed enabled higher precision by default, but not as high as was possible with the options before. The options were originally added to make Embree and Blender work correctly on Apple Silicion, and tested to need exactly this level of precision.
|
Thank @brechtvl for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores support for SSE2NEON_PRECISE_DIV and SSE2NEON_PRECISE_SQRT with the same level of precision that they had before deprecation in #580.
That changed enabled higher precision by default, but not as high as was possible with the options before. The options were originally added to make Embree and Blender work correctly on Apple Silicion, and tested to need exactly this level of precision.
It would be helpful for Blender not to have to maintain either a patched sse2neon or work with different tolerances on x86 and ARM.