Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executors: rework GCC/Clang executors #1155

Merged
merged 1 commit into from
Dec 31, 2023
Merged

executors: rework GCC/Clang executors #1155

merged 1 commit into from
Dec 31, 2023

Conversation

quantum5
Copy link
Member

Changes:

  • Make -std flags explicit everywhere.
  • Clang no longer inherits from GCC.
  • All C and C-like executors now inherit from CLikeExecutor.
  • Add -std=f95 for F95 executor.
  • CLANGX now correctly passes -std=c++14.

@quantum5 quantum5 requested a review from Xyene December 31, 2023 02:39
Xyene
Xyene approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quantum5 @Xyene
executors: rework GCC/Clang executors
53e2766 
Changes:

* Make -std flags explicit everywhere.
* Clang no longer inherits from GCC.
* All C and C-like executors now inherit from CLikeExecutor.
* Add -std=f95 for F95 executor.
* CLANGX now correctly passes -std=c++14.

Co-authored-by: Tudor Brindus <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc641b3) 82.77% compared to head (53e2766) 82.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         141      140    -1     
  Lines        5311     5313    +2     
=======================================
+ Hits         4396     4398    +2     
  Misses        915      915

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xyene Xyene merged commit accffd0 into master Dec 31, 2023
18 of 19 checks passed
@Xyene Xyene deleted the clang-std-flag branch December 31, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xyene Xyene Xyene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quantum5 @codecov-commenter @Xyene