-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executors/OBJC: fix executor #1158
Conversation
Can one of the admins verify this patch? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 82.99% 82.91% -0.08%
==========================================
Files 141 141
Lines 5362 5373 +11
==========================================
+ Hits 4450 4455 +5
- Misses 912 918 +6 ☔ View full report in Codecov by Sentry. |
ok to test |
In what way does it fail if you don't allow |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
prctl
with 23.~/GNUstep
, but this directory doesn't exist. I didRecursiveDir('~')
to work around this issue.initialize(cls)
doesn't run. I wroteautoconfig(cls)
to do the setup.apt-get install make gnustep-devel
to the DMOJ dockerfile.