judge: fix the mypy error in CI #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
===========================================
+ Coverage 49.37% 82.89% +33.51%
===========================================
Files 143 143
Lines 5430 5436 +6
===========================================
+ Hits 2681 4506 +1825
+ Misses 2749 930 -1819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kiritofeng
reviewed
Sep 21, 2024
| for cls in (PlatformX86Mixin, PlatformX64Mixin, PlatformARMMixin, PlatformARM64Mixin) | ||
| if cls.abi == NATIVE_ABI | ||
| ), | ||
| UnknownPlatformMixin, |
There was a problem hiding this comment.
Yes it is👍🏼
There was a problem hiding this comment.
(update: Black likes it)
JasonLovesDoggo
force-pushed
the
fix_mypy_error
branch
from
6aa9688
to
419ca9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/DMOJ/judge-server/actions/runs/10466584470/job/28983707605
(https://github.com/mcpt/wlmoj-judge/actions/runs/10975887920/job/30476034151) for a successful run