-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message and update saving message for plan writing #3232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @pengyin-shan I just have a small comment on the wording of one of the messages. I think it might be useful to run it by the PMs
<span class="label label-warning status" style="display:none;" data-status="saving"> | ||
<%= _("Saving...Please do not refresh or go to another page!") %> | ||
<br><br> | ||
<%= sanitize(_("If you stuck on this message, please save your plan to a separate file and contact us at %{helpdesk_email} .") % { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "If you are stuck on this message" might be confusing since it doesn't let them know what is supposed to happen (e.g. how long is 'stuck'?).
Suggest we change the messaging (maybe ask the PMs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "If you are stuck on this message" might be confusing since it doesn't let them know what is supposed to happen (e.g. how long is 'stuck'?).
Suggest we change the messaging (maybe ask the PMs)
How about "If this message doesn't disappear in 1 minute?" @mariapraetzellis how do you feel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariapraetzellis @dsisu : one more UI message suggestion is needed. For anyone sticking on the 'Saving...' message because of a system problem, we need them to remember not to fresh the page and to contact the helpdesk immediately.
Instead of saying If you are stuck on this message, please save your plan to a separate file and contact us at %{helpdesk_email}
, any suggestions you have?
@mariapraetzellis @dsisu can you have a look at the wording for these messages and let us know what would be appropriate? |
The PR is ready as long as the PM agrees with the final version of the message. Once they reach the final decision, the developer can just update the messages in I added CHANGELOG already, and updated Github actions to use node 16 so all test pass. |
Apologies for not responding sooner. Am I too late? Which screens are we talking about exactly, at which point in the process of writing a plan are these messages meant to appear? Thanks. |
These messages are supposed to show when saving the plan is not work as expected. We used to have users stuck on saving plan, but we didn't give any error message, so the user refreshed the page and all answers are gonna. We want to prove this situation because user will lost all the inputs. |
This ticket is created as an improvement for a user's plan-saving problem. The user so far only sees 'Saving...' and 'Answered by...' messages after saving the plan successfully.
However, a user of DMP Assistant was stuck on the 'Saving' message and no explicit guidance showed that if the user turns to other tabs now, the content in the rich text box will be lost and unrecovered. So she lost all her inputs of plan content.
Thus:
error-saving
span. We used to have nothing in it.Changes proposed in this PR:
Please let me know if you have any suggestions for these messages!