update DODOFeeRouteProxy #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attens1423
reviewed
Sep 6, 2024
| @@ -492,6 +511,13 @@ contract DODOFeeRouteProxy is Ownable { | |||
|
|
|||
| receiveAmount = receiveAmount - routeFee - brokerFee; | |||
| require(receiveAmount >= minReturnAmount, "DODORouteProxy: Return amount is not enough"); | |||
|
|
|||
| if (receiveAmount > expReturnAmount) { | |||
There was a problem hiding this comment.
这里，因为都有一笔routeFeeReceiver的转出，可以和上一笔合并吗，即上一笔先不转出，判断如果有正滑点，转出正滑点+手续费。事件换个名字，叫positiveSlippage之类比较好，还是只记录正滑点的数额
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.