Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #14988 stream dataTypes and builtinFunctions highlight #153

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

liuxy0551
Copy link
Collaborator

@liuxy0551 liuxy0551 commented Oct 30, 2024

改动

  • 部分数据类型高亮,这次只添加了 INT
  • 部分内置函数枚举,这里实际可以不添加,因为子产品中接口会返回,会 concat 进来,但为了防止后续由 monaco-sql-languages 实现所有函数的高亮,这里刚好排查添加上
  • NOT IN 带空格的函数高亮(其他类型也可以)

自测

使用 0.12.3-beta.4 beta 包在实时中已验证
image

@liuxy0551 liuxy0551 requested a review from Cythia828 October 30, 2024 12:14
Copy link
Collaborator

@Cythia828 Cythia828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有过滤functionskeywords里重合的关键字吗

// Type Conversion Functions
'CAST',
'TRY_CAST',
'TYPEOF',
// Collection Functions
'CARDINALITY',
'ELEMENT',
'array',
'map',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array map 是不是也应该统一大写?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档中是小写,已按照我们编写的规则统一改为大写

@liuxy0551
Copy link
Collaborator Author

有过滤functionskeywords里重合的关键字吗

有优先级,会体现在后方的前后顺序里
image
image

@liuxy0551 liuxy0551 changed the base branch from main to next November 18, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants