Fixes a decade old ZAS issue #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaedalusDock-Services
pushed a commit
that referenced
this pull request
Aug 20, 2023
Kapu1178
added a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Said quirk is pretty simple, when an airlock closes, the turf leaves the zone and takes it's share of air with it. Sounds fine, right? Well, it's fine until that share contains dangerous gas, because then when the airlock re-opens, it reintroduces the dangerous gas to the atmosphere.
My solution was actually pretty simple. Instead of using the simple zas_update_loc helper, I wrote some wrapper code around it specifically for doors to utilize when running close().
Changelog
🆑
fix: Doors of all kinds will no longer "trap" dangerous gas inside when closing.
/:cl: