Flavor Text returns #575
Flavor Text returns #575
Conversation
| @@ -343,6 +343,19 @@ | |||
| else if(isobserver(user)) | |||
| . += span_info("<b>Traits:</b> [get_quirk_string(FALSE, CAT_QUIRK_ALL)]") | |||
|
|
|||
| var/flavor_text_link | |||
| /// The first 1-FLAVOR_PREVIEW_LIMIT characters in the mob's "flavor_text" DNA feature. FLAVOR_PREVIEW_LIMIT is defined in flavor_defines.dm. | |||
| var/preview_text = copytext_char((dna.features["flavor_text"]), 1, FLAVOR_PREVIEW_LIMIT) | |||
There was a problem hiding this comment.
Really not a fan of this being stored in DNA.features.
There was a problem hiding this comment.
As long as storing it elsewhere does not replicate the problem I have seen in other servers where when the client disconnects, their flavor text doesnt go with the client which causes weird issues. @Kapu1178
There was a problem hiding this comment.
May be best to store it in mind instead.
Actually that's a stupid idea due to that being transferred with the brain IIRC, just write it to a var on the mob. Maybe it could be reused for giving other mobs extra examine info too, though that might be out of scope.
| if(istype(user, /mob/dead/new_player)) | ||
| var/mob/dead/new_player/player = user | ||
| player.new_player_panel() |
There was a problem hiding this comment.
This is rather odd, what's it for?
| return button_element(prefs, "Set Examine Text", "pref_act=[type]") | ||
|
|
||
| /datum/preference/text/flavor_text/user_edit(mob/user, datum/preferences/prefs) | ||
| var/input = tgui_input_text(user, "Describe your character in greater detail.",, serialize(prefs.read_preference(type))) |
There was a problem hiding this comment.
Needs a sensible length limit. You also might want to make this a multi-line input and strip out the newline characters after.
|
An additional safety measure, should a flavortext contain a link, the link (and associated user and character) needs to be logged in ADMINLOG, so that the content of the link can be verified. Might need to work with Kapu on that. I am requesting this for the sake of administrations sanity. I will be writing policy regarding Flavortext and passing it for administration and the leads approval before this is merged. |
|
They won't embed. Embedding player-written HTML is never intentional. It is no different than a player putting a link in papercode, or in chat. |
|
Thats fine. I dont want it to embed, just have the link logged so we can check it. |
I don't think thats necessary at all. it is the same as papercode/chat. |
|
After discussing with the leads, we'll just make links against the rules for flavortext. 2-3k characters is fine for the text limit imo. |
fuck no 4-6k is INSANE, people do not need to be writing autobiographies |
|
|
Ill deal with it later, dw |
|
@Cenrus Please address remaining reviews |
About The Pull Request
Reimplements flavor text. OOC notes not included
Why It's Good For The Game
It's hard to express your character with the ss13 sprite limitations so some short sentences can do wonders.
Changelog
🆑
add: Flavor text reintroduced
/:cl: