Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when attempting to browse files of logo partition on Smash #12

Closed
roblabla opened this issue Dec 14, 2018 · 5 comments
Closed

Crash when attempting to browse files of logo partition on Smash #12

roblabla opened this issue Dec 14, 2018 · 5 comments
Labels
duplicate This issue or pull request already exists fixed Fixed bug

Comments

@roblabla
Copy link

While trying to browser the logo partition of Smash, I got a fatal screen. It seems to crash in the getGameCardTitleIDAndVersion function. The stacktrace and memory dump is in the zip attached here.

gcdumptool_crash.zip

@DarkMatterCore
Copy link
Owner

@roblabla

Hi there. Sorry for taking so long to answer, a lot of things have happened in my personal life in the past few months, and they have kept me busy enough to stop browsing the Internet as much as I'd like.

This problem seems to be related to #4. Could you please try out the attached test build? I have enabled manual HFS0 partition header parsing in it, replacing the partition filesystem mounting steps through fs-srv calls. Hopefully, it should work.

gcdumptool_test_20190422.zip

@DarkMatterCore DarkMatterCore added the duplicate This issue or pull request already exists label Apr 22, 2019
@DarkMatterCore
Copy link
Owner

This was already confirmed to be working by @fennectech using a test build with yet-to-be-pushed changes (check issue #13). I'll close this issue and make a proper release in a few hours.

If you run into other problems, please, feel free to open another issue or to reopen this one! Thanks.

@fennectech
Copy link

Godspeed!

@DarkMatterCore
Copy link
Owner

Fixed in d22add4.

@DarkMatterCore
Copy link
Owner

@roblabla

While we're still at it (I hope *not* to have lost your interest in this just yet!), I noticed you're one of the maintainers of the SwIPC project. First of all, let me thank you, because I wouldn't have been able to get the application running up to this point without all that documentation.

That being said, would you be able to give some insight regarding issue #5? I've been trying to track down that bug for a few months now and, other than pinpointing it as being the result of calling OpenGameCardStorage at least once, I've been unable to achieve anything else. It doesn't matter if the call itself fails or not.

Any input on this topic would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists fixed Fixed bug
Projects
None yet
Development

No branches or pull requests

3 participants