Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent spawn child to be terminated by parent #264

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Prevent spawn child to be terminated by parent #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/command-handlers/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Command } from 'commander';
import { spawn } from 'child_process';
import { spawnSync } from 'child_process';
import { getVaultContent, initVaultContent } from '../modules/database/index.js';
import { logger } from '../logger.js';

Expand All @@ -18,14 +18,13 @@ export const runExec = async (_options: unknown, program: Command) => {
}

// spawn a new process with the command
const child = spawn(command, {
const child = spawnSync(command, {
stdio: 'inherit',
shell: true,
env: environmentVariables,
});

// listen for process exit
child.on('exit', (code) => {
logger.debug(`Child process exited with code ${code ?? 'unknown'}`);
});
if (child.error) {
logger.error(`Failed to execute command: ${child.error.message}`);
}
};
Loading