Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reliability fixes to testsortAzul (#4210) #4234

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Nov 6, 2024

Ticket

Closes #4210.

Reviewers

@MillenniumFalconMechanic .

Changes

  • Altered AnVIL-CMG sort tests as follows
    1. Load the specified tab
    2. Check that the first column starts with the "sort icon" visible
    3. Click the first column sort button
    4. Check that the sort icon is still visible
    5. For all other default columns:
    6. Check that the sort icon is not visible
    7. Click the sort button
    8. Check that the first cell in that column is visible (just to check nothing's broken, it doesn't need to have text)
    9. Check that the sort icon for the previous column is not visible
    10. Check that the sort icon for the current column is visible

Known Issues

  • Uses a toHaveCSS assertion to check whether cells are visible, since currently test icons just have opacity set to 0 when not visible, which Playwright doesn't check. Could avoid this with a test id or other attribute if desired

@jpaten jpaten linked an issue Nov 6, 2024 that may be closed by this pull request
@github-actions github-actions bot added the canary Done by the Clever Canary team label Nov 6, 2024
Copy link
Contributor

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jonah!

@jpaten jpaten merged commit 88717dd into main Nov 8, 2024
4 checks passed
@jpaten jpaten deleted the jonah/4210-update-sort-tests branch November 8, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sort tests to reduce the number of API calls and data dependence
2 participants