FE-203 disable test load hca e2e #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbst-broad
approved these changes
Apr 4, 2024
bahill
merged commit dfca3fe
into
FE-187-remove-copy_project-pipeline-and-tests
9 checks passed
bahill
added a commit
that referenced
this pull request
Apr 8, 2024
* remove test_copy_project, copy_project_to_new_dataset_job (unused and calls copy_project which I'm about to delete as well), copy_project pipeline solids, copy_project pipeline solids test, copy_project pipeline, remove copy_project test config, remove copy_project import * linting for style * Update requirements.txt * removing unused copy_project related config * Adding concurrency limiter - IE if a new push for the PR comes through stop the previously running jobs, if any. * add sleep to load_hca to see if the e2e issue is time sensitive. * FE-203 disable test load hca e2e (#333) --------- Co-authored-by: dsp-fieldeng-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
FE-203
This PR
Disables the test_load_hca e2e test as it was consistently failing against dev TDR/BQ.
The TDR team wants me to refactor to test against prod.
Drew and I discussed this and felt that a refactor was out of scope at this time, so I am disabling and will then run a quick smoke test on dev before deploying to prod (as per usual) as well as a smoke test on prod after deploy (as per usual).
In a future sprint I will dig into why TDR dev/BQ dev are not scaled or provisioned in the same manner as prod.
Merging into FE-187 to deploy and test with the removal of extraneous tests.
Checklist