-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Pact consumer tests for TPS #1577
Draft
samanehsan
wants to merge
15
commits into
develop
Choose a base branch
from
se/DR-3357-tps-consumer-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required upgrading to gradle 7.5
samanehsan
force-pushed
the
se/DR-3357-tps-consumer-tests
branch
from
January 17, 2024 00:44
396b017
to
318852f
Compare
This action is from terra-workspace-manager: https://github.com/DataBiosphere/terra-workspace-manager/blob/main/.github/workflows/consumer_contract_tests.yml
This could not be mocked as a record
samanehsan
force-pushed
the
se/DR-3357-tps-consumer-tests
branch
from
January 17, 2024 01:04
318852f
to
18eb5db
Compare
samanehsan
force-pushed
the
se/DR-3357-tps-consumer-tests
branch
2 times, most recently
from
January 17, 2024 18:47
5b60f83
to
fc9e1b6
Compare
samanehsan
force-pushed
the
se/DR-3357-tps-consumer-tests
branch
from
January 17, 2024 18:59
fc9e1b6
to
75542bf
Compare
- Update pact provider version - Update groovy library - required by pact (will this break the logback config?)
…o se/DR-3357-tps-consumer-tests
Also add id and policy name parameters
Replace pact dsl with JSON string
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 4 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/DR-3357
Changes:
POST /api/policy/v1alpha1/pao
PATCH /api/policy/v1alpha1/pao/{snapshot_id}
DELETE /api/policy/v1alpha1/pao/{snapshot_id}
PolicyServiceConfiguration
from a record back to a class in order to mock the API access token.Note: This is a draft PR because the TPS provider is still under development and the exact state names will change. We also need to work out the level of granularity for each request, for instance, how should we test creating different types of policies for a snapshot?