Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-755: Use workload identity to auth as staging test runner SA for staging smoke tests #1838

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

snf2ye
Copy link
Contributor

@snf2ye snf2ye commented Oct 16, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/DCJ-755

Addresses

Yale manages the key for the test runner service account. This does not automatically sync with the terraform that manages the secrets for github actions.

Switching to workload identity fixes this problem: Yale can manage the key and key rotation and it will sync with workload identity.

Summary of changes

  • Following these instructions
  • Update staging smoke tests to use workload identity instead of github secret

Related Changes

Testing Strategy

  • Run action from branch once terraform change is applied

Cherry pick action

Successful test run: https://github.com/DataBiosphere/jade-data-repo/actions/runs/11441504960/job/31829699245

@snf2ye snf2ye requested a review from a team as a code owner October 16, 2024 20:22
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor early suggestion:

Comment on lines 9 to 11
permissions:
contents: 'read'
id-token: 'write'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put these permissions at the job level:

jobs:
  test-runner-staging:
    runs-on: ubuntu-latest
    permissions:
      contents: 'read'
      id-token: 'write'

@snf2ye snf2ye force-pushed the sh/dcj-755-staging-testrunnersa branch from ead90ca to 4e15e49 Compare October 21, 2024 13:58
Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants