-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCJ-755: Use workload identity to auth as staging test runner SA for staging smoke tests #1838
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor early suggestion:
permissions: | ||
contents: 'read' | ||
id-token: 'write' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put these permissions at the job level:
jobs:
test-runner-staging:
runs-on: ubuntu-latest
permissions:
contents: 'read'
id-token: 'write'
ead90ca
to
4e15e49
Compare
… contact as TDR SA
… google auth java library
Quality Gate passedIssues Measures |
Jira ticket: https://broadworkbench.atlassian.net/browse/DCJ-755
Addresses
Yale manages the key for the test runner service account. This does not automatically sync with the terraform that manages the secrets for github actions.
Switching to workload identity fixes this problem: Yale can manage the key and key rotation and it will sync with workload identity.
Summary of changes
Related Changes
Testing Strategy
Cherry pick action
Successful test run: https://github.com/DataBiosphere/jade-data-repo/actions/runs/11441504960/job/31829699245