Add validation query and testOnBorrow to ensure we do not attempt to use invalid connections #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbst-broad
changed the title
…use invalid connections
aherbst-broad
force-pushed
the
arh-validation-query-exp
branch
from
a476be1
to
808f2d9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPM dev tests flaked on 10/4, with the error message "terminating connection due to administrator command". My hypothesis is that is due to Google Cloud SQL maintenance overnight invalidating connections in BPM's pool.
This PR adds a simple validation query and enforces that connections are tested at borrow-time before being returned on consumers.