TSPS-174 renaming non cosmetic things from tsps to teaspoons #93

jsotobroad · 2024-06-17T16:30:56Z

Description

We decided to rename out internal short name from tsps to teaspoons. This is making the changes in our repo first so we know what downstream things we should look into changing and try to merge the changes in logical order

working workflow with the consolidated db changesets - https://bvdp-saturn-dev.appspot.com/#workspaces/teaspoons-imputation-dev/teaspoons_imputation_dev_control_workspace_20240726/job_history/89bce976-a937-4829-bbe7-ad7d4e5dece8

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-174

jsotobroad · 2024-06-17T16:31:18Z

.github/workflows/build-and-test.yml

@@ -138,8 +138,8 @@ jobs:
          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
        with:
          status: failure
-          channel: "#terra-tsps-alerts"
-          username: "TSPS push to main branch"
+          channel: "#terra-teaspoons-alerts"


how hard is it to change slack channel names?

jsotobroad · 2024-06-17T16:31:55Z

README.md

@@ -82,7 +82,7 @@ SonarQube and want to debug the problem locally, you need to get the sonar token
 before running the gradle task.

 ```shell
-export SONAR_TOKEN=$(vault read -field=sonar_token secret/secops/ci/sonarcloud/tsps)
+export SONAR_TOKEN=$(vault read -field=sonar_token secret/secops/ci/sonarcloud/teaspoons)


do we want to change our vault path?

good question for @choover-broad

jsotobroad · 2024-06-17T16:32:15Z

README.md


 For more information about deployment to dev, check out DevOps' [excellent documentation](https://docs.google.com/document/d/1lkUkN2KOpHKWufaqw_RIE7EN3vN4G2xMnYBU83gi8VA/).

 ### Tracing

 We use [OpenTelemetry](https://opentelemetry.io/) for tracing, so that every request has a tracing span that can 
-be viewed in [Google Cloud Trace](https://cloud.google.com/trace). (This is not yet fully set up here - to be done in TSPS-107). 
+be viewed in [Google Cloud Trace](https://cloud.google.com/trace). (This is not yet fully set up here - to be done in Teaspoons-107). 


can we change the shortname of our jira board/tickets easily and what do we rename it to if it is?

jsotobroad · 2024-06-17T16:34:01Z

service/src/main/resources/application.yml

@@ -9,7 +9,7 @@ env:
      pass: ${DATABASE_USER_PASSWORD:dbpwd}
      user: ${DATABASE_USER:dbuser}
    stairway:
-      name: ${STAIRWAY_DATABASE_NAME:tsps_stairway_db}
+      name: ${STAIRWAY_DATABASE_NAME:teaspoons_stairway_db}


def need to make sure these database values are changed upstream

yeah i wonder what the process will be for updating BEEs

mmorgantaylor · 2024-06-17T17:00:22Z

.github/workflows/build-and-test.yml

@@ -138,8 +138,8 @@ jobs:
          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
        with:
          status: failure
-          channel: "#terra-tsps-alerts"
-          username: "TSPS push to main branch"
+          channel: "#terra-teaspoons-alerts"


mmorgantaylor · 2024-06-17T17:39:08Z

README.md

@@ -82,7 +82,7 @@ SonarQube and want to debug the problem locally, you need to get the sonar token
 before running the gradle task.

 ```shell
-export SONAR_TOKEN=$(vault read -field=sonar_token secret/secops/ci/sonarcloud/tsps)
+export SONAR_TOKEN=$(vault read -field=sonar_token secret/secops/ci/sonarcloud/teaspoons)


good question for @choover-broad

mmorgantaylor · 2024-06-17T17:39:41Z

README.md


 For more information about deployment to dev, check out DevOps' [excellent documentation](https://docs.google.com/document/d/1lkUkN2KOpHKWufaqw_RIE7EN3vN4G2xMnYBU83gi8VA/).

 ### Tracing

 We use [OpenTelemetry](https://opentelemetry.io/) for tracing, so that every request has a tracing span that can 
-be viewed in [Google Cloud Trace](https://cloud.google.com/trace). (This is not yet fully set up here - to be done in TSPS-107). 
+be viewed in [Google Cloud Trace](https://cloud.google.com/trace). (This is not yet fully set up here - to be done in TEASPOONS-107). 


did we decide on a new Jira handle yet?

i dont think we have. I thougth i put a comment about that somewhere but i dont see it =/

mmorgantaylor · 2024-06-17T17:40:50Z

service/src/main/java/bio/terra/pipelines/App.java

@@ -26,7 +26,7 @@
      "bio.terra.common.retry.transaction",
      // Stairway initialization and status
      "bio.terra.common.stairway",
-      // Scan all TSPS service packages
+      // Scan all Teaspoons service packages


should we change the whole "pipelines" package to "teaspoons"? (referenced in the next line)

i actually like pipelines. Similar to like workspace manager, their package name is workspace

mmorgantaylor · 2024-06-17T17:41:42Z

service/src/main/java/bio/terra/pipelines/dependencies/cbas/CbasService.java

@@ -43,11 +43,11 @@ public MethodListResponse getAllMethods(String cbasBaseUri, String accessToken)
   * .methodDescription("method description") //
   * .methodSource(PostMethodRequest.MethodSourceEnum.GITHUB) // .methodUrl(pipeline.getWdlUrl()) //
   * .methodVersion("1.0"); // logger.info( // "this is creating a new method in cbas: {}", //
-   * cbasService.createMethod( // cbasUri, samService.getTspsServiceAccountToken(),
+   * cbasService.createMethod( // cbasUri, samService.getTeasponnsServiceAccountToken(),


typo (though I kinda love "teasponns" 😂 )

its so hard to spell it sometimes!!!

mmorgantaylor · 2024-06-17T17:42:24Z

service/src/main/java/bio/terra/pipelines/dependencies/sam/SamService.java

    try {
      GoogleCredentials creds =
          GoogleCredentials.getApplicationDefault().createScoped(SAM_OAUTH_SCOPES);
      creds.refreshIfExpired();
      return creds.getAccessToken().getTokenValue();
    } catch (IOException e) {
      throw new InternalServerErrorException(
-          "Internal server error retrieving TSPS credentials", e);
+          "Internal server error retrieving Teaspoons credentials", e);


does this message get returned to the user? do we want a different user-facing name?

oh thats a good point, should we say Terra Scientific Pipeline Services instead?

mmorgantaylor · 2024-06-17T17:46:30Z

service/src/main/java/bio/terra/pipelines/dependencies/stairway/JobService.java

@@ -155,7 +155,8 @@ public <T> JobResultOrException<T> retrieveJobResult(

      switch (flightState.getFlightStatus()) {
        case FATAL:
-          logAlert("TSPS Stairway flight {} encountered dismal failure", flightState.getFlightId());
+          logAlert(
+              "Teaspoons Stairway flight {} encountered dismal failure", flightState.getFlightId());


we probably don't need to include "teaspoons" in these log messages at all...

mmorgantaylor · 2024-06-17T17:49:21Z

service/src/main/resources/application.yml

@@ -9,7 +9,7 @@ env:
      pass: ${DATABASE_USER_PASSWORD:dbpwd}
      user: ${DATABASE_USER:dbuser}
    stairway:
-      name: ${STAIRWAY_DATABASE_NAME:tsps_stairway_db}
+      name: ${STAIRWAY_DATABASE_NAME:teaspoons_stairway_db}


yeah i wonder what the process will be for updating BEEs

sonarcloud · 2024-06-26T20:14:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

… changes

jsotobroad · 2024-11-07T00:13:37Z

service/src/main/resources/db/changesets/20241106-base-data-insertion.yaml

+                  value: imputation
+              - column:
+                  name: wdl_url
+                  value: https://github.com/broadinstitute/warp/blob/TSPS-183_mma_beagle_imputation_hg38/pipelines/broad/arrays/imputation_beagle/ImputationBeagle.wdl


wasnt sure if this was correct but i think this is the latest value we have

sonarcloud · 2024-11-07T00:21:58Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jsotobroad requested a review from mmorgantaylor June 17, 2024 16:30

jsotobroad commented Jun 17, 2024

View reviewed changes

mmorgantaylor reviewed Jun 17, 2024

View reviewed changes

jsotobroad force-pushed the js_TSPS-174 branch 4 times, most recently from f675487 to e1813d1 Compare June 26, 2024 20:09

jsotobroad changed the title ~~TSPS-174 first pass at renaming things from tsps to teaspoons~~ TSPS-174 renaming non cosmetic things from tsps to teaspoons Jun 26, 2024

jsotobroad force-pushed the js_TSPS-174 branch from e1813d1 to 9bdcf67 Compare November 6, 2024 16:57

Jose Soto added 3 commits November 6, 2024 16:36

first pass at renaming things from tsps to teaspoons for non cosmetic…

e84b9bd

… changes

consilidate changesets before releasing teaspoons

a89ca40

get consolidate changesets working with tests and against dev

44fcd84

jsotobroad force-pushed the js_TSPS-174 branch from 9bdcf67 to 44fcd84 Compare November 7, 2024 00:12

jsotobroad commented Nov 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TSPS-174 renaming non cosmetic things from tsps to teaspoons #93

TSPS-174 renaming non cosmetic things from tsps to teaspoons #93

jsotobroad commented Jun 17, 2024 •

edited

Loading

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

mmorgantaylor Jun 17, 2024

mmorgantaylor Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

jsotobroad Jun 17, 2024

mmorgantaylor Jun 17, 2024

sonarcloud bot commented Jun 26, 2024

jsotobroad Nov 7, 2024

sonarcloud bot commented Nov 7, 2024

TSPS-174 renaming non cosmetic things from tsps to teaspoons #93

Are you sure you want to change the base?

TSPS-174 renaming non cosmetic things from tsps to teaspoons #93

Conversation

jsotobroad commented Jun 17, 2024 • edited Loading

Description

Jira Ticket

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 26, 2024

Quality Gate passed

Choose a reason for hiding this comment

sonarcloud bot commented Nov 7, 2024

Quality Gate passed

jsotobroad commented Jun 17, 2024 •

edited

Loading