Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BENCH-826] Split GCP path formats / functions from MockMvcUtils (pr 1) #1394

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[BENCH-826] Split GCP path formats / functions from MockMvcUtils (pr 1) #1394

merged 1 commit into from
Jul 21, 2023

Conversation

dexamundsen
Copy link
Contributor

@dexamundsen dexamundsen commented Jul 19, 2023 •
edited
Loading

  • Part 2 of: Split MockMvcUtils to platform based components -> MockGcpApi (new) with Gcp path formats
  • moves functions of AiNotebooks, GCE Instance, DataProc cluster, BQ tables and BQ datasets
  • Rename Path formats in MockGcpApi to keep them consistent
  • Move few util functions to specific test files

Part 3 will move functions of objects and buckets in next PR

@dexamundsen dexamundsen changed the base branch from main to dexamundsen/bench-826-copy July 19, 2023 02:59
@dexamundsen dexamundsen changed the title [BENCH-826] Split GCP path formats / functions from MockMvcUtils [BENCH-826] Split GCP path formats / functions from MockMvcUtils (pr 1) Jul 19, 2023
@dexamundsen dexamundsen changed the base branch from dexamundsen/bench-826-copy to main July 19, 2023 20:45
@dexamundsen dexamundsen marked this pull request as ready for review July 20, 2023 06:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dexamundsen dexamundsen mentioned this pull request Jul 20, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dexamundsen dexamundsen requested a review from nfoen July 21, 2023 04:42
@dexamundsen dexamundsen merged commit 1a59299 into main Jul 21, 2023
7 checks passed
@dexamundsen dexamundsen deleted the dexamundsen/bench-826-gcp branch July 21, 2023 16:46
@zloery zloery mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerwangcs rogerwangcs rogerwangcs approved these changes

@zloery zloery zloery approved these changes

@yuhuyoyo yuhuyoyo Awaiting requested review from yuhuyoyo

@mikenev mikenev Awaiting requested review from mikenev

@nfoen nfoen Awaiting requested review from nfoen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dexamundsen @zloery @rogerwangcs