Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BENCH-826] move MockMvcUtils to mocks package #1404

Merged
merged 2 commits into from
Jul 27, 2023
Merged

[BENCH-826] move MockMvcUtils to mocks package #1404

merged 2 commits into from
Jul 27, 2023

Conversation

dexamundsen
Copy link
Contributor

@dexamundsen dexamundsen commented Jul 25, 2023 •
edited
Loading

This is the final PR in cleanup of mockMvcUtils.

  • Moves MockMvcUtils to 1mocks' package
  • Groups functions within this file

no other functional / test changes

@dexamundsen dexamundsen changed the base branch from main to dexamundsen/main-copy July 25, 2023 05:51
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@dexamundsen dexamundsen force-pushed the dexamundsen/bench-826-cleanup branch from 133dddd to 69570df Compare July 26, 2023 18:34
@dexamundsen dexamundsen changed the base branch from dexamundsen/main-copy to main July 26, 2023 18:34
@dexamundsen dexamundsen changed the title [BENCH-826] Cleanup of MockMvcUtils [BENCH-826] move MockMvcUtils to mocks package Jul 26, 2023
@dexamundsen dexamundsen marked this pull request as ready for review July 26, 2023 18:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nfoen
nfoen approved these changes Jul 27, 2023
View reviewed changes
Copy link

@nfoen nfoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dexamundsen dexamundsen merged commit c4e3bf1 into main Jul 27, 2023
14 checks passed
@dexamundsen dexamundsen deleted the dexamundsen/bench-826-cleanup branch July 27, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfoen nfoen nfoen approved these changes

@rogerwangcs rogerwangcs rogerwangcs approved these changes

@zloery zloery Awaiting requested review from zloery

@yuhuyoyo yuhuyoyo Awaiting requested review from yuhuyoyo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dexamundsen @rogerwangcs @nfoen