Update readme #1783
Merged
Update readme #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbst-broad
requested review from
a team,
blakery and
marctalbott
and removed request for
a team
aherbst-broad
commented
Aug 9, 2024
| [Releasing our Code](https://broadworkbench.atlassian.net/wiki/spaces/WOR/pages/2974449675/Releasing+our+Code) | ||
| in Confluence. | ||
|
|
||
| ## Setup | ||
|
|
||
| ### Prerequisites: | ||
|
|
||
| #### Postgres | ||
| We are currently using Postgres 13.1. |
There was a problem hiding this comment.
I don't think running WSM with a local postgres is supported anymore (I'm unaware of anyone running in this mode). I want to centralize on a single approach for turning on the DB.
There was a problem hiding this comment.
I don't think anyone really runs postgres outside of a docker container anywhere, anymore.
aherbst-broad
commented
Aug 9, 2024
| WSM has latent support for _applications_. No applications exist at this time. The concept | ||
| is that an application is a distinguished service account. Owners of the workspace can | ||
| control which applications are allowed access to the workspace. If an application is given | ||
| WSM has latent support for _applications_. [Leonardo](https://github.com/DataBiosphere/leonardo) is the only |
There was a problem hiding this comment.
Small change re: leo
aherbst-broad
commented
Aug 9, 2024
| @@ -383,9 +374,7 @@ local WSM: | |||
| For Broad deployment, those are: | |||
|
|
|||
| - dev: https://workspace.dsde-dev.broadinstitute.org/swagger-ui.html | |||
| - alpha: https://workspace.dsde-alpha.broadinstitute.org/swagger-ui.html | |||
There was a problem hiding this comment.
These envs are dead.
blakery
approved these changes
Aug 9, 2024
| [Releasing our Code](https://broadworkbench.atlassian.net/wiki/spaces/WOR/pages/2974449675/Releasing+our+Code) | ||
| in Confluence. | ||
|
|
||
| ## Setup | ||
|
|
||
| ### Prerequisites: | ||
|
|
||
| #### Postgres | ||
| We are currently using Postgres 13.1. |
There was a problem hiding this comment.
I don't think anyone really runs postgres outside of a docker container anywhere, anymore.
|
marctalbott
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README. The bulk of the changes are me running the README through a formatter, I've called out the substantive changes in breadcrumb comments.